fix(app): avoid desktop blank screen from modulepreload polyfill#1045
Conversation
This keeps production release artifacts unchanged while ensuring staging sidecar, bundle lookup, and upload paths align with debug outputs. Made-with: Cursor
Serialize env-mutating core_process tests with a shared lock so OPENHUMAN_* overrides do not race under parallel test execution in CI. Made-with: Cursor
Prevent startup blank-screen crashes in desktop builds where `link.relList.supports` is present but not callable by turning off the injected modulepreload polyfill. Made-with: Cursor
📝 WalkthroughWalkthroughThe PR updates the CI/CD release workflow to use profile-dependent build paths ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
597-605: 💤 Low valueSentry symbol upload paths still hardcoded to
release.The Sentry debug symbol upload step at lines 599 and 627 uses hardcoded
releasein the path:deps_dir="target/${MATRIX_TARGET}/release/deps"For staging builds (which now use
debugprofile), this path won't exist, so the upload will be silently skipped. While this is acceptable because staging builds skip Sentry uploads anyway (guarded byrelease_enabled == 'true'), the code could be confusing for future maintainers.Consider updating for consistency, or adding a comment explaining the guard makes this moot:
- deps_dir="target/${MATRIX_TARGET}/release/deps" + # Only runs for production (release_enabled == 'true'), so 'release' profile is correct + deps_dir="target/${MATRIX_TARGET}/release/deps"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 597 - 605, Replace the hardcoded "release" path used to build deps_dir so it respects the build profile; e.g., change deps_dir="target/${MATRIX_TARGET}/release/deps" to use a profile variable like deps_dir="target/${MATRIX_TARGET}/${MATRIX_PROFILE:-release}/deps" (ensure MATRIX_PROFILE is set in the matrix or defaults to "release"), or alternatively add a brief comment next to the deps_dir assignment referencing the release_enabled guard; update occurrences around the Sentry upload step and the variable names MATRIX_TARGET, MATRIX_PROFILE and release_enabled to keep behavior consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/release.yml:
- Around line 597-605: Replace the hardcoded "release" path used to build
deps_dir so it respects the build profile; e.g., change
deps_dir="target/${MATRIX_TARGET}/release/deps" to use a profile variable like
deps_dir="target/${MATRIX_TARGET}/${MATRIX_PROFILE:-release}/deps" (ensure
MATRIX_PROFILE is set in the matrix or defaults to "release"), or alternatively
add a brief comment next to the deps_dir assignment referencing the
release_enabled guard; update occurrences around the Sentry upload step and the
variable names MATRIX_TARGET, MATRIX_PROFILE and release_enabled to keep
behavior consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dce2d1c2-3bd8-4fbe-8342-b94414dad217
📒 Files selected for processing (3)
.github/workflows/release.ymlapp/src-tauri/src/core_process_tests.rsapp/vite.config.ts
Summary
app/vite.config.tsfor desktop buildslink.relList.supportscan be truthy but non-callableTest plan
pnpm --filter openhuman-app build