fix(app): guard modulepreload relList.supports for CEF#1050
Conversation
This keeps production release artifacts unchanged while ensuring staging sidecar, bundle lookup, and upload paths align with debug outputs. Made-with: Cursor
Serialize env-mutating core_process tests with a shared lock so OPENHUMAN_* overrides do not race under parallel test execution in CI. Made-with: Cursor
Prevent startup blank-screen crashes in desktop builds where `link.relList.supports` is present but not callable by turning off the injected modulepreload polyfill. Made-with: Cursor
…ts issues. Introduced a new Vite plugin to replace unsafe usage of relList.supports with a safer check, preventing potential crashes in desktop CEF builds. Updated modulePreload configuration to disable the polyfill for improved stability.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates the Desktop CEF runtime workaround in Vite configuration by disabling modulepreload and adding a post-build plugin that guards Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
Summary
relList.supports(\"modulepreload\")check to requiretypeof relList.supports === \"function\"build.modulePreload = falseso both modulepreload and dynamic-import preload paths avoid the non-callablerelList.supportscrashTest plan
pnpm lintpnpm typecheckMade with Cursor
Summary by CodeRabbit