Docs/yarn to pnpm#938
Merged
Merged
Conversation
- Document aarch64 build process in BUILDING.md - Add gtk::init() in tauri-runtime-cef before tray creation - This fixes 'GTK has not been initialized' panic on ARM Linux
- Update AGENTS.md, CONTRIBUTING.md, PLAN.md commands - Update docs/ directory (BUILDING, E2E-TESTING, sentry, etc.) - Update .claude/ and .agents/ agent instructions
Contributor
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 27 minutes and 22 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR systematically replaces Yarn package manager invocations with pnpm across agent configuration files, documentation, and workflow guides, updating frontend quality checks (typecheck, lint, format, test), development commands, and build workflows. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/BUILDING.md (1)
103-307:⚠️ Potential issue | 🟠 MajorRemove accidental duplicated document blocks (merge/paste artifact).
From Line 103 onward, the guide content is duplicated (including repeated headings and troubleshooting sections), which breaks flow and makes instructions ambiguous.
Suggested cleanup
-# Building & Installing OpenHuman -... -## Troubleshooting -... -### macOS: `pnpm dev:app` exits with "CEF cache is held by another OpenHuman instance" +<!-- Remove the duplicated block starting at Line 103 through the second repeated +troubleshooting heading, keeping only one canonical copy of each section. -->🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/BUILDING.md` around lines 103 - 307, The file contains a duplicated block of the build/install documentation starting around the "ARM Linux Build (aarch64)" section (including repeated "GTK initialization fix" and "Troubleshooting" headers); remove the accidental duplicate paragraph(s) so only one copy of each section remains, keeping the first complete version and deleting the second repeated block (look for headings "ARM Linux Build (aarch64)", "GTK initialization fix", and "Troubleshooting" to locate the duplicate content), and verify the document ends cleanly with a single Troubleshooting section.
🧹 Nitpick comments (2)
CONTRIBUTING.md (1)
116-116: Tighten Tauri guidance to avoid directwindow.__TAURI__checks.The phrasing can be read as endorsing direct global checks; prefer documenting
try/catcharound Tauri wrappers (orisTauri()helper) as the default pattern.Based on learnings: Applies to app/src/**/*.{ts,tsx} : Use
isTauri()fromapp/src/services/webviewAccountService.tsor wrapinvoke(...)intry/catch. Do not checkwindow.__TAURI__directly at module load.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CONTRIBUTING.md` at line 116, Update the Tauri guidance to discourage direct global checks of window.__TAURI__ and instruct authors to use the isTauri() helper or wrap invoke(...) calls in try/catch instead; reference the existing helper isTauri() in app/src/services/webviewAccountService.ts and recommend using it (or protecting calls to invoke from `@tauri-apps/api`) at runtime rather than checking window.__TAURI__ at module load time so modules can safely load outside Tauri.docs/superpowers/plans/2026-04-21-command-palette-plan.md (1)
153-155: Use repo-relative commands instead of a machine-specific absolute path.Line 153 hardcodes
/Users/jwalinshah/..., which makes the plan non-portable. Prefer repo-relative instructions (e.g.,cd appfrom repo root) so anyone can execute it as-is.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/superpowers/plans/2026-04-21-command-palette-plan.md` around lines 153 - 155, The plan currently uses a machine-specific absolute path ("cd /Users/jwalinshah/projects/openhuman-frontend/app"); change this to a repo-relative command such as "cd app" (or "cd ./app") and add a brief preface like "from the repository root" so the instructions are portable and runnable by anyone; update the text in docs/superpowers/plans/2026-04-21-command-palette-plan.md to replace the absolute path with the repo-relative form.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/agents/pr-manager-lite.md:
- Around line 111-114: The CI commands currently call `pnpm typecheck` which
doesn't exist in app/package.json; update the script invocation to `pnpm
compile` instead. Locate the shell block that runs `cd app && pnpm typecheck`
and replace that invocation with `cd app && pnpm compile` so the pipeline runs
the existing `compile` (tsc --noEmit) script; leave the subsequent `pnpm lint`,
`pnpm format`, and `pnpm test:unit` lines unchanged.
In @.claude/memory.md:
- Line 19: Update the checklist entry that currently instructs to run `pnpm
typecheck` so it matches the renamed command referenced later (`pnpm workspace
openhuman-app compile`); locate the checklist line in .claude/memory.md and
replace or reword `pnpm typecheck` to `pnpm workspace openhuman-app compile` (or
a generic “run the workspace compile/typecheck command”) so the document is
consistent with the "typecheck renamed" note.
In `@CONTRIBUTING.md`:
- Line 29: Replace the incorrect package manager name "Yarn" with "pnpm" in the
prerequisites bullet that currently reads "[Node.js](https://nodejs.org/) (LTS)
and [Yarn](https://pnpmpkg.com/)" so the text and link are consistent with the
pnpm-based workflow; update the markdown text to mention "pnpm" (keeping the
existing pnpm link) to avoid confusion.
In `@docs/src/04-mcp-system.md`:
- Line 39: The command in the doc is invalid; replace the incorrect "pnpm
workspace openhuman-app test" with the correct pnpm workspace-targeting syntax
using --filter, e.g. "pnpm --filter openhuman-app test" (or "pnpm --filter
openhuman-app run test" if you intend to run the package's test script
explicitly) so the documentation shows a valid pnpm command.
---
Outside diff comments:
In `@docs/BUILDING.md`:
- Around line 103-307: The file contains a duplicated block of the build/install
documentation starting around the "ARM Linux Build (aarch64)" section (including
repeated "GTK initialization fix" and "Troubleshooting" headers); remove the
accidental duplicate paragraph(s) so only one copy of each section remains,
keeping the first complete version and deleting the second repeated block (look
for headings "ARM Linux Build (aarch64)", "GTK initialization fix", and
"Troubleshooting" to locate the duplicate content), and verify the document ends
cleanly with a single Troubleshooting section.
---
Nitpick comments:
In `@CONTRIBUTING.md`:
- Line 116: Update the Tauri guidance to discourage direct global checks of
window.__TAURI__ and instruct authors to use the isTauri() helper or wrap
invoke(...) calls in try/catch instead; reference the existing helper isTauri()
in app/src/services/webviewAccountService.ts and recommend using it (or
protecting calls to invoke from `@tauri-apps/api`) at runtime rather than checking
window.__TAURI__ at module load time so modules can safely load outside Tauri.
In `@docs/superpowers/plans/2026-04-21-command-palette-plan.md`:
- Around line 153-155: The plan currently uses a machine-specific absolute path
("cd /Users/jwalinshah/projects/openhuman-frontend/app"); change this to a
repo-relative command such as "cd app" (or "cd ./app") and add a brief preface
like "from the repository root" so the instructions are portable and runnable by
anyone; update the text in
docs/superpowers/plans/2026-04-21-command-palette-plan.md to replace the
absolute path with the repo-relative form.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ffedf5f7-d85e-4062-a3da-e996fa0998be
📒 Files selected for processing (23)
.agents/agents/pr-manager-lite.md.agents/agents/pr-manager.md.claude/agents/pr-manager-lite.md.claude/agents/pr-manager.md.claude/agents/pr-reviewer.md.claude/agents/qualityqueen.md.claude/memory.mdAGENTS.mdCONTRIBUTING.mdPLAN.mddocs/BUILDING.mddocs/E2E-TESTING.mddocs/NOTIFICATION_TESTING_STATUS.mddocs/RELEASE_POLICY.mddocs/SUMMARY.mddocs/install.mddocs/sentry.mddocs/src/04-mcp-system.mddocs/superpowers/learnings/2026-04-21-imessage-harness-session.mddocs/superpowers/plans/2026-04-21-command-palette-plan.mddocs/superpowers/plans/2026-04-21-imessage-live-harness.mddocs/superpowers/specs/2026-04-21-command-palette-design.mddocs/webview-integration-playbook.md
- Replace incorrect 'pnpm typecheck' with 'pnpm compile' in pr-manager-lite.md and memory.md - Fix 'Yarn' to 'pnpm' in CONTRIBUTING.md prerequisites - Update Tauri guidance to recommend isTauri() helper instead of direct window.__TAURI__ checks - Fix invalid pnpm workspace command syntax in 04-mcp-system.md - Remove duplicate ARM Linux build and troubleshooting sections in BUILDING.md - Replace absolute path with repo-relative path in command-palette-plan.md
senamakel
approved these changes
Apr 26, 2026
6 tasks
AusAgentSmith
pushed a commit
to AusAgentSmith/openhuman
that referenced
this pull request
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yarnreferences withpnpmin documentation files after the migration was completed in previous PRsProblem
Documentation and agent instructions still contained outdated
yarncommands after the repo migrated to pnpm in an earlier PR.Solution
Systematically replaced all yarn references with pnpm in:
Submission Checklist
Impact