[codex] Align E2E docs with CEF reality#1464
Merged
senamakel merged 1 commit intoMay 11, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR updates E2E testing infrastructure documentation and build commands to clarify Linux CEF automation limitations and migrate from yarn to pnpm. The workflow files add diagnostic headers explaining that Linux tauri-driver cannot drive CEF-backed WebViews, while all shell scripts and CI job configurations switch build commands to pnpm with --filter syntax. The development guide is comprehensively updated to reflect these platform constraints and revised commands. ChangesE2E Platform Limitations and Build Command Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/scripts/e2e-run-spec.sh (1)
119-123: ⚡ Quick winRemove the duplicated bundle URL guard.
Line 119 repeats the exact same check already done at Line 114, so this second block is redundant and easy to accidentally diverge.
Proposed cleanup
-if ! grep -q "127.0.0.1:${E2E_MOCK_PORT}" "$DIST_JS"; then - echo "ERROR: frontend bundle does NOT contain mock server URL (127.0.0.1:${E2E_MOCK_PORT})." >&2 - echo " Run 'pnpm test:e2e:build' to rebuild with the mock URL." >&2 - exit 1 -fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/scripts/e2e-run-spec.sh` around lines 119 - 123, The script contains a duplicated guard that checks for the mock URL in the built bundle using grep on "$DIST_JS" with "127.0.0.1:${E2E_MOCK_PORT}" — remove the second identical block (the repeated if ! grep -q ... then echo ... exit 1 fi) so only the original check remains; ensure you keep the existing error messages and exit code exactly as-is and do not alter the variable names E2E_MOCK_PORT or DIST_JS.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app/scripts/e2e-run-spec.sh`:
- Around line 119-123: The script contains a duplicated guard that checks for
the mock URL in the built bundle using grep on "$DIST_JS" with
"127.0.0.1:${E2E_MOCK_PORT}" — remove the second identical block (the repeated
if ! grep -q ... then echo ... exit 1 fi) so only the original check remains;
ensure you keep the existing error messages and exit code exactly as-is and do
not alter the variable names E2E_MOCK_PORT or DIST_JS.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0935cd83-42c8-4874-beb6-59f47278f580
📒 Files selected for processing (6)
.github/workflows/e2e-agent-review.yml.github/workflows/test.ymlapp/scripts/e2e-agent-review.shapp/scripts/e2e-run-all-flows.shapp/scripts/e2e-run-spec.shgitbooks/developing/e2e-testing.md
12 tasks
AusAgentSmith
pushed a commit
to AusAgentSmith/openhuman
that referenced
this pull request
May 23, 2026
Co-authored-by: Jwalin Shah <jshah1331@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates E2E scripts, GitBook docs, and workflow comments to use pnpm wording and describe current CEF automation limits accurately.
Impact
Prevents agents and CI readers from treating disabled Linux WebDriver paths as the default supported route.
Validation
Wave I replacement branch:
codex/100x-impl-openhuman-e2e-cef-docs-upstreamCommit:
4405ff6c76f0b347f77c66256bd00efcfff6deefOpened as draft for review; no deploys, merges, or tracker mutations were performed. Supersedes #1463, which was based on a stale fork branch.
Summary by CodeRabbit
Documentation
Chores