gdrive: add gdrive_user_credentials_file description#1192
Conversation
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Suggestions and questions
| `.dvc/tmp/gdrive-user-credentials.json` and they will be used automatically next | ||
| time you run DVC. |
There was a problem hiding this comment.
| `.dvc/tmp/gdrive-user-credentials.json` and they will be used automatically next | |
| time you run DVC. | |
| `.dvc/tmp/gdrive-user-credentials.json` by default, and they will be loaded | |
| automatically next time you use the same GDrive remote. |
There was a problem hiding this comment.
this is not exactly true, they can be used for multiple remotes if you don't specify an option gdrive_user_credentials_file
There was a problem hiding this comment.
Got it. But "run DVC" doesn't sound exact either. How about
| `.dvc/tmp/gdrive-user-credentials.json` and they will be used automatically next | |
| time you run DVC. | |
| `.dvc/tmp/gdrive-user-credentials.json` by default, and they will be loaded | |
| automatically next time you use this or other GDrive remotes. |
Maybe even continue this paragraph with the explanation about how to overwrite it, instead of a separate paragraph that repeats the file name.
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
| If you use multiple GDrive remotes, by default they will be sharing the same | ||
| `.dvc/tmp/gdrive-user-credentials.json` credentials file. It can be overridden |
There was a problem hiding this comment.
Maybe we don't need to repeat the file name since it's mentioned in in the previous paragraph (before the warning).
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
I just thing the part around the credentials file name and how to overwrite it could be merged into a single paragraph or something like that to avoid repetition and going back and forth on the same idea.
2 participants
Corresponding core DVC PR treeverse/dvc#3686
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏