gdrive: fix multi-remote workflow, cont. cleanup#3686
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3686 +/- ##
==========================================
- Coverage 90.77% 90.65% -0.12%
==========================================
Files 158 158
Lines 10001 10018 +17
==========================================
+ Hits 9078 9082 +4
- Misses 923 936 +13
Continue to review full report at Codecov.
|
Contributor
jorgeorpinel
left a comment
There was a problem hiding this comment.
Questions and suggestions on cmd output.
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-Authored-By: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
c9480fa to
238d6ed
Compare
jorgeorpinel
approved these changes
Apr 28, 2020
238d6ed to
5adb714
Compare
efiop
reviewed
Apr 29, 2020
efiop
reviewed
Apr 29, 2020
efiop
reviewed
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address more checkboxes from the #2865.
Specifically:
gdrive_user_credentials_fileis handled - it should be resolved against config location if it is relative.Docs PR: treeverse/dvc.org#1192
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏