Skip to content

Added a reference to dvc cache dir in shared-development-server page#1316

Merged
jorgeorpinel merged 11 commits into
treeverse:masterfrom
PseudoNerd:doc-update
May 26, 2020
Merged

Added a reference to dvc cache dir in shared-development-server page#1316
jorgeorpinel merged 11 commits into
treeverse:masterfrom
PseudoNerd:doc-update

Conversation

@PseudoNerd
Copy link
Copy Markdown
Contributor

@PseudoNerd PseudoNerd commented May 19, 2020

fix #986
Modified shared-development-server page to show the usage of dvc cache dir command and added a description to the dvc cache dir page for better understanding.

@jorgeorpinel
Copy link
Copy Markdown
Contributor

jorgeorpinel commented May 19, 2020

Please link to the issue this PR addresses or closes (see https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue). This is mentioned in the pull request template. There's no need to delete that text BTW 🙂

Comment thread content/docs/command-reference/cache/dir.md Outdated
Comment thread content/docs/command-reference/cache/dir.md Outdated
Comment thread content/docs/use-cases/shared-development-server.md Outdated
@jorgeorpinel
Copy link
Copy Markdown
Contributor

Thanks for the updates @PseudoNerd I'll check them out ASAP. Please notice the CI test is failing at the md format check (see https://circleci.com/gh/iterative/dvc.org/3556). Did you setup the local dev environment completely as explained in the contrib guide? #1321 was opened automatically to fix the formatting (so you could merge that for now), but ideally you can keep the formatting same from your IDE, enjoying the Git hooks that check this for you before git push.

@PseudoNerd

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

Comment thread content/docs/command-reference/cache/dir.md Outdated
Comment thread content/docs/command-reference/cache/dir.md Outdated
Comment thread content/docs/command-reference/cache/dir.md Outdated
Comment thread content/docs/use-cases/shared-development-server.md Outdated
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main changes to content/docs/use-cases/shared-development-server.md are correct but the other changes have some issues.

@shcheklein shcheklein temporarily deployed to dvc-landing-doc-update-lkfeqdr May 21, 2020 21:33 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-doc-update-lkfeqdr May 22, 2020 09:23 Inactive
Comment thread content/docs/use-cases/shared-development-server.md Outdated
@PseudoNerd PseudoNerd requested a review from jorgeorpinel May 23, 2020 01:26
@shcheklein shcheklein temporarily deployed to dvc-landing-doc-update-lkfeqdr May 23, 2020 01:35 Inactive
Comment thread content/docs/command-reference/cache/dir.md Outdated
Comment thread content/docs/command-reference/cache/dir.md Outdated
@shcheklein shcheklein temporarily deployed to dvc-landing-doc-update-lkfeqdr May 25, 2020 06:33 Inactive
@PseudoNerd PseudoNerd requested a review from jorgeorpinel May 25, 2020 06:35
@jorgeorpinel
Copy link
Copy Markdown
Contributor

Thank you @PseudoNerd! Let's chat about your project ideas soon, and if you can please continue to contribute to other small issues when you have time.

@jorgeorpinel jorgeorpinel merged commit 0000b67 into treeverse:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use-cases: use 'dvc cache dir' command in shared dev server

3 participants