Skip to content

Restyle Added a reference to dvc cache dir in shared-development-server page#1321

Closed
restyled-io[bot] wants to merge 8 commits into
masterfrom
restyled/pull-1316
Closed

Restyle Added a reference to dvc cache dir in shared-development-server page#1321
restyled-io[bot] wants to merge 8 commits into
masterfrom
restyled/pull-1316

Conversation

@restyled-io
Copy link
Copy Markdown
Contributor

@restyled-io restyled-io Bot commented May 19, 2020

A duplicate of #1316 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • prettier

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/iterative/dvc.org.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-wmysrr May 19, 2020 20:02 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/pull-1316 branch from abed4c1 to e6be4ea Compare May 19, 2020 20:02
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-wmysrr May 19, 2020 20:03 Inactive
@calibre-analytics
Copy link
Copy Markdown

calibre-analytics Bot commented May 19, 2020

Comparing Restyle Added a reference to dvc cache dir in shared-development-server page Snapshot #5 to median since last deploy of DVC.org.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
94
no change
980ms
from 1.1s
3.7s
from 3.9s
Chrome Desktop
Chrome • Cable
100
no change
570ms
from 450ms
1.9s
from 1.6s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
88
from 81
1.4s
from 1.6s
5.1s
from 6.2s

3 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
7.4 KB
from 37 KB
Lighthouse Performance Score
MotoG4, 3G connection
88
from 76
 Docs

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
58 KB
from 160 KB
Total JSON size in bytes
MotoG4, 3G connection
14 KB
from 28 KB
Total Page size in bytes
Chrome Desktop
1.2 MB
from 1.3 MB
 Blog

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
69 KB
from 130 KB
Total JSON size in bytes
MotoG4, 3G connection
69 KB
from 91 KB

Calibre: Site dashboard | View this PR | Edit settings

@restyled-io restyled-io Bot force-pushed the restyled/pull-1316 branch from e6be4ea to 342736d Compare May 19, 2020 20:22
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-wmysrr May 19, 2020 20:22 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/pull-1316 branch from 342736d to 885f543 Compare May 19, 2020 20:28
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-wmysrr May 19, 2020 20:29 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/pull-1316 branch from 885f543 to 4113282 Compare May 19, 2020 20:34
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-wmysrr May 19, 2020 20:34 Inactive
@jorgeorpinel
Copy link
Copy Markdown
Contributor

Hmmm this is strange. I thought Restyled used to make PRs into PR branches (meta) but this is going straight to master. In this case the original PR (#1316) is from an outside contributor so maybe that's the reason? Same problem with #1329 and #1319.

#1310 in contrast worked properly, as a PR into the feature branch (inside the upstream). Cc @shcheklein

@jorgeorpinel
Copy link
Copy Markdown
Contributor

p.s. opened #1330 about this. I think I'm going to close all this bad Restyled PRs for now and explain the situation to the contributors.

@shcheklein shcheklein deleted the restyled/pull-1316 branch June 30, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants