Skip to content

Restyle Fix #1033 user-guide: add more links to the .dvcignore guide from other docs#1329

Closed
restyled-io[bot] wants to merge 47 commits into
masterfrom
restyled/pull-1328
Closed

Restyle Fix #1033 user-guide: add more links to the .dvcignore guide from other docs#1329
restyled-io[bot] wants to merge 47 commits into
masterfrom
restyled/pull-1328

Conversation

@restyled-io
Copy link
Copy Markdown
Contributor

@restyled-io restyled-io Bot commented May 21, 2020

A duplicate of #1328 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • prettier

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/iterative/dvc.org.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-2ywpah May 21, 2020 13:04 Inactive
@calibre-analytics
Copy link
Copy Markdown

calibre-analytics Bot commented May 21, 2020

Comparing Restyle Fix #1033 user-guide: add more links to the .dvcignore guide from other docs Snapshot #4 to median since last deploy of DVC.org.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
94
no change
1s
no change
3.6s
from 3.7s
Chrome Desktop
Chrome • Cable
100
no change
550ms
from 450ms
1.8s
from 1.7s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
89
from 81
1.4s
from 1.5s
4.9s
from 6.2s

3 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
7.4 KB
from 67 KB
Total JSON size in bytes
MotoG4, 3G connection
7.5 KB
from 13 KB
Lighthouse Performance Score
MotoG4, 3G connection
89
from 74
 Docs

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
58 KB
from 270 KB
Total JSON size in bytes
MotoG4, 3G connection
14 KB
from 41 KB
Total Page size in bytes
Chrome Desktop
1.2 MB
from 1.4 MB
 Blog

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
69 KB
from 190 KB
Total JSON size in bytes
MotoG4, 3G connection
69 KB
from 110 KB
Total Page size in bytes
Chrome Desktop
1.1 MB
from 1.2 MB

Calibre: Site dashboard | View this PR | Edit settings

@jorgeorpinel
Copy link
Copy Markdown
Contributor

Closing this per #1330

@shcheklein
Copy link
Copy Markdown
Contributor

A duplicate of #1328 with additional commits that automatically address
incorrect style, created by Restyled.

This should be merged instead of the main PR when main PR is ready.

@jorgeorpinel
Copy link
Copy Markdown
Contributor

I see. Hmmm

@shcheklein shcheklein deleted the restyled/pull-1328 branch June 30, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants