Skip to content

Restyle Draft of the new remote rename command#1319

Closed
restyled-io[bot] wants to merge 3 commits into
masterfrom
restyled/pull-1318
Closed

Restyle Draft of the new remote rename command#1319
restyled-io[bot] wants to merge 3 commits into
masterfrom
restyled/pull-1318

Conversation

@restyled-io
Copy link
Copy Markdown
Contributor

@restyled-io restyled-io Bot commented May 19, 2020

A duplicate of #1318 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • prettier

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/iterative/dvc.org.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-pu-wigks5 May 19, 2020 14:14 Inactive
@calibre-analytics
Copy link
Copy Markdown

calibre-analytics Bot commented May 19, 2020

Comparing Restyle Draft of the new remote rename command Snapshot #4 to median since last deploy of DVC.org.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
92
from 94
1.4s
from 990ms
4.3s
from 3.7s
Chrome Desktop
Chrome • Cable
99
from 100
930ms
from 470ms
2.5s
from 1.8s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
87
from 81
1.5s
from 1.6s
5.2s
from 6.2s

3 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
7.4 KB
from 67 KB
Largest Contentful Paint
MotoG4, 3G connection
1.5s
from 9.2s
Total JSON size in bytes
MotoG4, 3G connection
7.5 KB
from 13 KB
Lighthouse Performance Score
MotoG4, 3G connection
87
from 75
 Docs

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
Chrome Desktop
58 KB
from 270 KB
Total JSON size in bytes
MotoG4, 3G connection
14 KB
from 41 KB
Total Page size in bytes
Chrome Desktop
1.2 MB
from 1.4 MB
 Blog

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
First Contentful Paint
Chrome Desktop
1.3s
from 420ms
First Meaningful Paint
Chrome Desktop
1.3s
from 420ms
Speed Index
Chrome Desktop
1.5s
from 600ms
Time to Interactive
Chrome Desktop
2.5s
from 1.2s
First CPU Idle
Chrome Desktop
2.5s
from 1.2s

4 other significant changes: Largest Contentful Paint on Chrome Desktop, Total JSON size in bytes on Chrome Desktop, Total JSON size in bytes on MotoG4, 3G connection, Total Page size in bytes on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings

@jorgeorpinel
Copy link
Copy Markdown
Contributor

Closing this per #1330

@shcheklein shcheklein deleted the restyled/pull-1318 branch June 30, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants