new remote rename command#1318
Conversation
|
Not a native English speaker, and never wrote front-end code. Actually, I can't do much more than now. And If you had any change of the doc of help, I would synchronize it to the related PR |
|
This is perfect @karajan1001! We'll take it form here. Thank you so much. |
|
|
@jorgeorpinel That PR is merged now 🙂 |
This comment has been minimized.
This comment has been minimized.
|
we should also update (or make sure that they are up to date):
|
Thank you @shcheklein, I had opened a new issue treeverse/dvc/issues/3847 in the core repo to do this. But may I ask a question? I had never seen an autocompletion on any DVC commands and didn't know their existence. How can I make them come into effect? I am using zsh on both Linux and macOS and installed DVC from pip. |
|
Hey guys I cherry-picked @karajan1001's commits into my branch for #1283 instead of pushing here. I also fixed
and other general scaffolding stuff to put this doc in the right place. Closing this PR but thanks again! |
@karajan1001 Pip doesn't install those, unfortunately. You can install them manually using this guide https://dvc.org/doc/install/completion#shell-tab-completion . deb/rpm/brew packages automatically install it though. |
|
@jorgeorpinel let's merge this and do improvements on top? It's not good that we don't attribute commits and contributions properly this way. |
|
@shcheklein cherry-picking preserves the author of commits. But yeah, shame that this PR wasn't preserved. Though it is a common practice in many projects. |
|
@efiop @jorgeorpinel yep, I didn't check that Jorge did a cherry-pick. I think it's fine then if it's easier to manage the process this way. |
|
Yes the commits are preserved in the repo's history (unless you sqash the merge which we don't do AFAIK). But you're right it's better for the contributor to have a merged PR. Reopening, we can merge it, the result will be the same in the end! |
|
However let's wait for mine to merge first? It already has all the improvements to this 👍 Added a checkbox in #1283 (comment) |
|
@jorgeorpinel feel free to merge in any order :) I think both are approved? |
|
@jorgeorpinel @efiop @shcheklein |
fix #1301 (match treeverse/dvc/pull/3794)
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏