Add a new rename command #3794
Merged
Merged
Conversation
1. add new command `dvc remote rename <old> <new>`. 2. add tests for this new command.
Contributor
Author
|
Linked to iterative/dvc.org/issues/1301 |
Contributor
|
@karajan1001 Sorry for the delay, we'll review ASAP. |
pmrowla
suggested changes
May 19, 2020
Contributor
pmrowla
left a comment
pmrowla
left a comment
There was a problem hiding this comment.
Looks good, just a couple of minor issues
pared
approved these changes
May 19, 2020
Co-authored-by: Peter Rowlands (변기호) <peter@pmrowla.com>
Contributor
Author
|
@efiop Before merging, I think it is better to wait for possible suggestions from the document side |
pmrowla
approved these changes
May 19, 2020
karajan1001
commented
May 20, 2020
Contributor
|
Thank you @karajan1001 ! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #3599
dvc remote rename <old> <new>.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
cmd ref: document new subcommand
remote renamedvc.org#1301❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏