Skip to content

docs: misc. updates#1680

Merged
jorgeorpinel merged 28 commits into
masterfrom
jorge
Aug 13, 2020
Merged

docs: misc. updates#1680
jorgeorpinel merged 28 commits into
masterfrom
jorge

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel commented Aug 8, 2020 •
edited
Loading

@shcheklein shcheklein temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 8, 2020 22:11 Inactive
jorgeorpinel
jorgeorpinel commented Aug 8, 2020
View reviewed changes
Comment thread content/docs/command-reference/remote/add.md Outdated
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 8, 2020 22:16 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 8, 2020 22:24 Inactive
@jorgeorpinel jorgeorpinel changed the title cmd: rewrite sections about remote URLs cmd: rewrite sections and short descs. about URLs (remote, get/import-url) Aug 8, 2020
@jorgeorpinel jorgeorpinel mentioned this pull request Aug 8, 2020
Merged
2 tasks
shcheklein
shcheklein reviewed Aug 9, 2020
View reviewed changes
Comment thread content/docs/command-reference/remote/modify.md
shcheklein
shcheklein reviewed Aug 9, 2020
View reviewed changes
Comment thread content/docs/command-reference/remote/add.md Outdated
shcheklein
shcheklein reviewed Aug 9, 2020
View reviewed changes
Comment thread content/docs/command-reference/remote/add.md Outdated
shcheklein
shcheklein approved these changes Aug 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. there are some suggestions in the comments

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 10, 2020 00:44 Inactive
@jorgeorpinel jorgeorpinel changed the title cmd: rewrite sections and short descs. about URLs (remote, get/import-url) docs: misc. updates Aug 10, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 10, 2020 03:39 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 10, 2020 04:14 Inactive
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

jorgeorpinel commented Aug 10, 2020

Sorry @shcheklein , I added more stuff to this PR before realizing you had already approved it. Please check once more. Won't add anything else.

shcheklein
shcheklein reviewed Aug 10, 2020
View reviewed changes
Comment thread content/docs/user-guide/dvc-files-and-directories.md Outdated
shcheklein
shcheklein reviewed Aug 10, 2020
View reviewed changes
Comment thread content/docs/user-guide/troubleshooting.md Outdated
shcheklein
shcheklein suggested changes Aug 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few unresolved issues here

@jorgeorpinel jorgeorpinel mentioned this pull request Aug 11, 2020
Merged
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 11, 2020 05:23 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 11, 2020 22:53 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 11, 2020 22:55 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Aug 12, 2020
Closed
shcheklein
shcheklein reviewed Aug 12, 2020
View reviewed changes
Comment thread content/docs/user-guide/dvc-files-and-directories.md Outdated
shcheklein
shcheklein reviewed Aug 12, 2020
View reviewed changes
Comment thread content/docs/command-reference/remote/modify.md Outdated
example:

```dvc
$ dvc remote modify myremote url /home/user/dvcstore
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do s3 example and can even explain about s3 prefix, or do another example if needed in a separate block?

Copy link
Copy Markdown
Contributor Author

@jorgeorpinel jorgeorpinel Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK added S3 example before local example although I'm not sure it's needed as it's also in the S3 section. The S3 URL format is also explained in its section. See 3b7898e

shcheklein
shcheklein approved these changes Aug 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall - some comments still to address, approving so that you can merge when you see it's done more or less

jorgeorpinel added a commit that referenced this pull request Aug 12, 2020
@jorgeorpinel
cmd: remote name MUSt be unique
58c4eee 
#1680 (review)
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-jorge-pxovtkqzumjp August 13, 2020 03:49 Inactive
@jorgeorpinel jorgeorpinel merged commit 4ed790d into master Aug 13, 2020
@skshetry skshetry mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@efiop efiop efiop left review comments

@shcheklein shcheklein shcheklein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: insufficient description of params

3 participants

@jorgeorpinel @shcheklein @efiop