term: review "URL" term usage in remote cmds, and get/import-url#4364
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4364 +/- ##
==========================================
- Coverage 90.90% 90.89% -0.01%
==========================================
Files 178 178
Lines 12323 12323
==========================================
- Hits 11202 11201 -1
- Misses 1121 1122 +1
Continue to review full report at Codecov.
|
efiop
reviewed
Aug 12, 2020
Comment on lines
+34
to
+44
| "url", | ||
| help="Location of the data to download. Supported URLs:\n" | ||
| "/absolute/path/to/file/or/dir\n" | ||
| "relative/path/to/file/or/dir\n" | ||
| "C:\\\\path\\to\\file\\or\\dir\n" | ||
| "https://example.com/path/to/file\n" | ||
| "s3://bucket/key/path\n" | ||
| "gs://bucket/path/to/file/or/dir\n" | ||
| "hdfs://example.com/path/to/file\n" | ||
| "ssh://example.com/absolute/path/to/file/or/dir\n" | ||
| "remote://remote_name/path/to/file/or/dir (see `dvc remote`)", |
Contributor
There was a problem hiding this comment.
Why duplicate the effort though? Old redirection to import-url worked fine.
Contributor
There was a problem hiding this comment.
Suggested change
| "url", | |
| help="Location of the data to download. Supported URLs:\n" | |
| "/absolute/path/to/file/or/dir\n" | |
| "relative/path/to/file/or/dir\n" | |
| "C:\\\\path\\to\\file\\or\\dir\n" | |
| "https://example.com/path/to/file\n" | |
| "s3://bucket/key/path\n" | |
| "gs://bucket/path/to/file/or/dir\n" | |
| "hdfs://example.com/path/to/file\n" | |
| "ssh://example.com/absolute/path/to/file/or/dir\n" | |
| "remote://remote_name/path/to/file/or/dir (see `dvc remote`)", | |
| "url", help="See `dvc import-url -h` for full list of supported URLs." |
Contributor
Author
There was a problem hiding this comment.
I'd prefer to make it easier for the user (the effort is duplicated for them), but no strong opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
I try but pylint: crashing on commit #4357
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
This matches docs: misc. updates dvc.org#1680, actually.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏