term: must vs. should#1692
Merged
Merged
Conversation
jorgeorpinel
commented
Aug 12, 2020
jorgeorpinel
commented
Aug 12, 2020
jorgeorpinel
commented
Aug 12, 2020
jorgeorpinel
commented
Aug 12, 2020
shcheklein
reviewed
Aug 14, 2020
shcheklein
reviewed
Aug 14, 2020
| DVC can help you get a token by guiding you through the OAuth flow in the | ||
| browser. There you must consent to allow the _DVC_ Application to operate on | ||
| your behalf. The OAuth consent screen will describe the scope of what is being | ||
| browser. From there you can allow the _DVC_ Application to operate on your |
Contributor
There was a problem hiding this comment.
let's not change this legal language
Contributor
Author
There was a problem hiding this comment.
OK, changes undone. Should I avoid touching this file completely going fwd?
shcheklein
reviewed
Aug 14, 2020
shcheklein
reviewed
Aug 14, 2020
jorgeorpinel
force-pushed
the
term/should-must
branch
from
ca54bd0 to
cc00061
Compare
shcheklein
reviewed
Aug 16, 2020
| (e.g. [Minio](https://min.io/), | ||
| [DigitalOcean Spaces](https://www.digitalocean.com/products/spaces/), | ||
| [IBM Cloud Object Storage](https://www.ibm.com/cloud/object-storage) etc.) you | ||
| must explicitly configure the `endpointurl`: |
Contributor
There was a problem hiding this comment.
not sure about this one ... you must do this indeed
Contributor
Author
There was a problem hiding this comment.
Yes, that's what this says (it's just a long sentence): "To communicate with ... an S3 compatible API ... configure the remote's endpointurl explicitly". "Must" is very emphatic, I don't think we needed it here. It's still an imperative sentence, which tells you what you must do.
shcheklein
reviewed
Aug 16, 2020
shcheklein
approved these changes
Aug 16, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
approved ... just a few last comments
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
force-pushed
the
term/should-must
branch
from
a2d8bd7 to
5d73566
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+ some copy edits around the instances I did review (even if they weren't changed, e.g. a small improvement to the
remote addref)