checks: allow for multi-line code blocks#2060
Conversation
|
I ran |
|
I still don't quite understand what does this change exactly mean |
jorgeorpinel
had a problem deploying
to
dvc-landing-prettier-pr-tsp8dp
|
@shcheklein per https://prettier.io/docs/en/options.html#prose-wrap this means to "wrap markdown text as-is" (which BTW is the default behavior). So we should rather see why it was set to I guess it's about auto-breaking long lines... So perhaps you're right that this might have big implications... |
jorgeorpinel
temporarily deployed
to
dvc-landing-prettier-pr-tsp8dp
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Yeah with this change regular long lines in md don't get wrapped 🤦
| "printWidth": 80, | ||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "proseWrap": "always" |
There was a problem hiding this comment.
("preserve" is the default value anyway.)
| - performance.json | ||
| training: | ||
| desc: Training stage description | ||
| desc: Training stage description blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah |
There was a problem hiding this comment.
Long line in code block
| `dvc.yaml` files consists of a group of `stages` with names provided explicitly | ||
| by the user with the `--name` (`-n`) option of `dvc run`. Each stage can contain | ||
| the following fields: | ||
| the following fields blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah: |
There was a problem hiding this comment.
Long line in md
|
Ivan was right! |
2 participants
per #2054 (review)
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏