Skip to content

Restyle 2.0 Pipelines (parametrization)#2061

Closed
restyled-io[bot] wants to merge 1 commit into
2.0/pipelinesfrom
restyled/2.0/pipelines
Closed

Restyle 2.0 Pipelines (parametrization)#2061
restyled-io[bot] wants to merge 1 commit into
2.0/pipelinesfrom
restyled/2.0/pipelines

Conversation

@restyled-io
Copy link
Copy Markdown
Contributor

@restyled-io restyled-io Bot commented Dec 28, 2020

Automated style fixes for #2052, created by Restyled.

The following restylers made fixes:

  • prettier

To incorporate these changes, merge this Pull Request into the original. We
recommend using the Squash or Rebase strategies.

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 02:13 Inactive
Comment on lines 284 to +281
cmd: >-
python train.py
--tresh ${models.us.threshold}
--out ${models.us.filename}
python train.py --tresh ${models.us.threshold} --out ${models.us.filename}
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continues #2054 (review)

So we're back on square one per #2060 (review) @rogermparent 😆. Any other ideas?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal BTW, we could go with the "pretty" version. I just thought it would be interesting to show how advanced YAML is supported...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does prettier support some meta commands to disable it locally?

Copy link
Copy Markdown
Contributor

@rogermparent rogermparent Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaml accepts a # prettier-ignore comment, but we'll have to test out if that translates to frontmatter and works in the engine.

EDIT: Oops, this isn't front-matter, it's a code block. I just checked the full context. Markdown ignoring makes more sense.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger fixed this particular case in 088fbe8.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. related note in #2062 (review)

@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 95d8845 to 610af03 Compare December 28, 2020 02:39
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 02:39 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 610af03 to 7f23e93 Compare December 28, 2020 03:05
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 03:06 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 7f23e93 to 663026b Compare December 28, 2020 19:15
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 19:15 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 663026b to 76d42b9 Compare December 28, 2020 19:56
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 19:56 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 76d42b9 to fa929fb Compare December 28, 2020 20:04
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 20:04 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from fa929fb to 52f3bc2 Compare December 28, 2020 20:44
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 20:44 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 52f3bc2 to 5047528 Compare December 28, 2020 20:45
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 20:45 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 5047528 to 385fc14 Compare December 28, 2020 20:58
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 20:58 Inactive
@restyled-io restyled-io Bot force-pushed the restyled/2.0/pipelines branch from 385fc14 to ff772d3 Compare December 28, 2020 21:13
@shcheklein shcheklein temporarily deployed to dvc-landing-restyled-2--bwtirh December 28, 2020 21:13 Inactive
@restyled-io restyled-io Bot closed this Dec 28, 2020
@restyled-io restyled-io Bot deleted the restyled/2.0/pipelines branch December 28, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants