ref: add config --project flag and standardize the others by efiop · Pull Request #2064 · treeverse/dvc.org

efiop · 2020-12-30T01:30:45Z

Per treeverse/dvc#5179 (and treeverse/dvc#5399)

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

jorgeorpinel

A first quick suggested text for cache dir which can probably be generalized in other docs.

But I'm still not sure about the term repo vs. project... ⌛

jorgeorpinel · 2021-01-05T06:55:50Z

@efiop this change is bigger in docs than it seems from the OP and I only started reviewing for now. We may need several iterations. Thanks a lot for contributing this as we are pretty busy with the other 2.0 docs updates at the moment (see #2026).

Per treeverse/dvc.org#2064 Not changing the internal terminology because we stick to Repo in a lot of places there and adjusting all of it would be wasteful. Maybe in the future.

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

per #2154 (review)

efiop · 2021-03-18T21:31:34Z

@jorgeorpinel Could you take a look when you have time, please?

jorgeorpinel · 2021-03-28T18:05:31Z

@efiop sorry, this is one of the few ones that fell through the cracks but I'll take it over now. Thanks 👍

order --system first

jorgeorpinel · 2021-03-28T19:37:43Z

+- `--project` - save remote configuration to the project's config
+  (`.dvc/config`). Used by default.
+


Q @efiop: if this is used by default and remote add only writes to config, why even have the option here? When does it have an effect?

Same for remote modify/remove/rename

For symmetry mostly. Right now remtoe add/modify/remove/rename will just default to --project anyway.

Thanks @efiop. So just to be clear, the option in these commands never has an effect right?

Yes, it is the default behavior.

jorgeorpinel

Just a Q above but this is mergeable I think.

jorgeorpinel · 2021-03-31T17:16:46Z

Merged but we may want to delete the --project option from remote add/modify/remove/rename if it has no effect (see #2064 (review)).

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 01:31 Inactive

efiop force-pushed the efiop-dvc-5179 branch from b2470f8 to 9015bde Compare December 30, 2020 01:40

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 01:40 Inactive

efiop force-pushed the efiop-dvc-5179 branch from 9015bde to 020c55f Compare December 30, 2020 01:44

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 01:45 Inactive

efiop added the 2.0 release label Dec 30, 2020

efiop mentioned this pull request Dec 30, 2020

config: read merged config by default treeverse/dvc#5179

Merged

2 tasks

efiop force-pushed the efiop-dvc-5179 branch from 020c55f to 6e12e67 Compare December 30, 2020 17:57

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 17:58 Inactive

efiop force-pushed the efiop-dvc-5179 branch from 6e12e67 to 7ab9587 Compare December 30, 2020 18:00

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 18:00 Inactive

efiop requested a review from jorgeorpinel December 30, 2020 18:01

efiop changed the title ~~[WIP] docs: add --repo flag for config/remote~~ docs: add --repo flag for config/remote Dec 30, 2020

efiop changed the title ~~docs: add --repo flag for config/remote~~ [WIP] docs: add --repo flag for config/remote Dec 30, 2020

efiop force-pushed the efiop-dvc-5179 branch from 7ab9587 to 76c1518 Compare December 30, 2020 18:08

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 18:08 Inactive

efiop force-pushed the efiop-dvc-5179 branch from 76c1518 to 469d504 Compare December 30, 2020 18:09

shcheklein temporarily deployed to dvc-landing-efiop-dvc-5-r7iq4r December 30, 2020 18:09 Inactive

efiop changed the title ~~[WIP] docs: add --repo flag for config/remote~~ docs: add --repo flag for config/remote Dec 30, 2020

efiop commented Dec 30, 2020

View reviewed changes

Comment thread content/docs/command-reference/cache/dir.md Outdated

jorgeorpinel reviewed Jan 5, 2021

View reviewed changes

Comment thread content/docs/command-reference/cache/dir.md Outdated

Comment thread content/docs/command-reference/cache/dir.md Outdated

jorgeorpinel mentioned this pull request Jan 5, 2021

2.0 docs #2026

Closed

12 tasks

jorgeorpinel reviewed Jan 5, 2021

View reviewed changes

Comment thread content/docs/command-reference/cache/dir.md Outdated

jorgeorpinel reviewed Jan 5, 2021

View reviewed changes

Comment thread content/docs/command-reference/cache/dir.md Outdated

jorgeorpinel reviewed Jan 5, 2021

View reviewed changes

Comment thread content/docs/command-reference/config.md Outdated

jorgeorpinel mentioned this pull request Jan 7, 2021

config: rename config.local to config.private treeverse/dvc#3670

Closed

docs: add --project flag for config/remote

1a80f4e

efiop force-pushed the efiop-dvc-5179 branch from 469d504 to 1a80f4e Compare February 3, 2021 13:42

jorgeorpinel mentioned this pull request Feb 17, 2021

ref: add remote example in gc ref #154

Closed

efiop self-assigned this Feb 23, 2021

jorgeorpinel and others added 9 commits March 1, 2021 05:55

Merge branch 'master' into guide/external-disclaimer

4210bbf

Update content/docs/command-reference/cache/dir.md

611931f

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

Update content/docs/command-reference/config.md

b1f83cd

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

Update content/docs/command-reference/config.md

c3feb64

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

Update content/docs/command-reference/config.md

69ad9fc

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

Update content/docs/command-reference/config.md

daa6bfe

Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>

Merge branch 'master' into efiop-dvc-5179

b7482c9

Merge branch 'master' into guide/external-disclaimer

06cf1da

guide: revert Exp Outs guide rename

49eefb0

per #2154 (review)

jorgeorpinel added 4 commits March 28, 2021 09:04

Merge branch 'guide/external-disclaimer'

a4252f6

Merge branch 'master' of github.com:iterative/dvc.org

8f3de6e

Merge branch 'master' into efiop-dvc-5179

7758d3d

ref: stdize config file options

eacd0c6

jorgeorpinel assigned jorgeorpinel and unassigned efiop Mar 28, 2021

jorgeorpinel added 2 commits March 28, 2021 12:23

ref: remove too many notes on config files and

646cb74

order --system first

ref: more copy edits to config options

736a5dc

jorgeorpinel reviewed Mar 28, 2021

View reviewed changes

jorgeorpinel force-pushed the efiop-dvc-5179 branch from bbdd61b to 646cb74 Compare March 28, 2021 21:22

jorgeorpinel approved these changes Mar 28, 2021

View reviewed changes

jorgeorpinel changed the title ~~docs: add --project flag for config/remote~~ ref: add config --project flag and standardize the others Mar 28, 2021

jorgeorpinel removed their assignment Mar 28, 2021

jorgeorpinel merged commit e18739e into master Mar 31, 2021

shcheklein deleted the efiop-dvc-5179 branch April 4, 2021 02:46

jorgeorpinel mentioned this pull request Apr 16, 2021

remote: remove/hide --project option? treeverse/dvc#5828

Closed

		- `--project` - save remote configuration to the project's config
		(`.dvc/config`). Used by default.

Conversation

efiop commented Dec 30, 2020 • edited by jorgeorpinel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jorgeorpinel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jorgeorpinel commented Jan 5, 2021

Uh oh!

efiop commented Mar 18, 2021

Uh oh!

jorgeorpinel commented Mar 28, 2021

Uh oh!

jorgeorpinel Mar 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel Mar 28, 2021

Choose a reason for hiding this comment

Uh oh!

efiop Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

efiop Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel left a comment

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel commented Mar 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

efiop commented Dec 30, 2020 •

edited by jorgeorpinel

Loading

jorgeorpinel Mar 28, 2021 •

edited

Loading