Skip to content

config: read merged config by default#5179

Merged
efiop merged 4 commits into
treeverse:masterfrom
efiop:repo_config
Dec 30, 2020
Merged

config: read merged config by default#5179
efiop merged 4 commits into
treeverse:masterfrom
efiop:repo_config

Conversation

@efiop
Copy link
Copy Markdown
Contributor

@efiop efiop commented Dec 29, 2020

By default dvc config and dvc remote show repo project-level config in read-mode, but they should really use merged config instead, same as git config does. In write-mode we are doing everything right and write to project-level config by default.

Per #4841 and #5126

treeverse/dvc.org#2064

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop efiop changed the title config: read merged config by default [WIP] config: read merged config by default Dec 29, 2020
@efiop efiop force-pushed the repo_config branch 2 times, most recently from e803c63 to 047d71b Compare December 30, 2020 19:59
@efiop efiop changed the title [WIP] config: read merged config by default config: read merged config by default Dec 30, 2020
@efiop efiop merged commit 8162bb1 into treeverse:master Dec 30, 2020
@efiop efiop deleted the repo_config branch December 30, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant