dvcignore: initial description#263
Merged
Merged
Conversation
shcheklein
suggested changes
Apr 24, 2019
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Thaks @pared a lot!
When you have time, please take a look at the following improvements we can make:
- You need to register it in the
src/Documentation/sidebar.jsonso that it's visible in the navigation panel. - Should we name it as Git does - just
dvcignore? - Let's try to follow the same doc structure as we already have in commands reference. First one sentence on what it actually does. Then description (you already have it pretty much) .
- It's not actually clear from the description what is the current implementation doing. It describes the purpose but it's not clear what is it actually doing now.
- A simple example?
- Style - no trailing whitespaces
shcheklein
approved these changes
Apr 29, 2019
Contributor
|
Looks great, @pared . Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
Related to treeverse/dvc#1820