Skip to content

ignore: introduce .dvcignore#1820

Merged
efiop merged 1 commit into
treeverse:masterfrom
pared:1499
Apr 15, 2019
Merged

ignore: introduce .dvcignore#1820
efiop merged 1 commit into
treeverse:masterfrom
pared:1499

Conversation

@pared
Copy link
Copy Markdown
Contributor

@pared pared commented Apr 1, 2019

Fixes #1499
Related to #1863
Note: This implementation allows to ignore files via .dvcignore file placed in same directory as ignored file, or any parent directory. This behaviour is consistent with .gitignore ignore rules.

@pared pared changed the title [WIP] ignore: introduce .dvcignore ignore: introduce .dvcignore Apr 2, 2019
@pared pared requested a review from efiop April 2, 2019 03:44
Comment thread dvc/ignore.py Outdated
Comment thread dvc/ignore.py Outdated
Comment thread dvc/scm/tree.py Outdated
Comment thread dvc/ignore.py Outdated
Comment thread dvc/utils/__init__.py Outdated
Comment thread dvc/utils/fs.py Outdated
Comment thread requirements.txt Outdated
Comment thread dvc/utils/fs.py Outdated
Comment thread dvc/ignore.py Outdated
@efiop efiop requested a review from ei-grad April 5, 2019 13:15
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Apr 5, 2019

@ei-grad Please take a look. 🙂

@pared pared force-pushed the 1499 branch 6 times, most recently from a23e2a9 to cb0f6af Compare April 9, 2019 15:29
@pared pared force-pushed the 1499 branch 2 times, most recently from fc3d786 to 35aed5f Compare April 9, 2019 15:40
@pared pared force-pushed the 1499 branch 2 times, most recently from 2f0fcdb to 9ef1d81 Compare April 12, 2019 12:58
Comment thread dvc/ignore.py Outdated
Comment thread dvc/ignore.py Outdated
Comment thread dvc/scm/tree.py Outdated
Comment thread dvc/utils/fs.py Outdated
Comment thread dvc/utils/fs.py Outdated
Comment thread dvc/utils/fs.py Outdated
Comment thread tests/test_stage.py Outdated
Comment thread dvc/scm/tree.py Outdated
Comment thread tests/test_ignore.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use dir and file as var names, because they highlight as builtins.

Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc: support .dvcignore

2 participants