guide: DVC Project concept page#2754
Conversation
|
Would appreciate a quick review @casperdcl 🙏 |
| repository). It will contain the `.dvc/` directory, as well as `dvc.yaml` and | ||
| `.dvc` files created with commands such as `dvc add` or `dvc run`. | ||
| `.dvc` files created with commands such as `dvc add` or `dvc run`. | ||
| See [full concept](/doc/user-guide/basic-concepts/dvc-project). |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
auto-render if markdown (below) is non-empty?
Yes it was mentioned in #2453 (review) (well sort of -- auto-linking from Glossary) and discussed with the team but deemed not a priority (at all). Also related to #2755 (review)
There was a problem hiding this comment.
p.s. created #2771
p.p.s. I did apply the suggestion in this review.
| Initialized by running `dvc init` in you <abbr>workspace</abbr> directory, it | ||
| will contain all the [DVC files and directories][dvc-metafiles] including the | ||
| <abbr>cache</abbr>, `dvc.yaml` and `.dvc` files, etc. Any other files referenced | ||
| from these DVC metafiles are also considered part of the project (for example | ||
| [metrics files](/doc/command-reference/metrics)). |
There was a problem hiding this comment.
| Initialized by running `dvc init` in you <abbr>workspace</abbr> directory, it | |
| will contain all the [DVC files and directories][dvc-metafiles] including the | |
| <abbr>cache</abbr>, `dvc.yaml` and `.dvc` files, etc. Any other files referenced | |
| from these DVC metafiles are also considered part of the project (for example | |
| [metrics files](/doc/command-reference/metrics)). | |
| Initialized by running `dvc init` in your <abbr>workspace</abbr> directory, a | |
| DVC project will contain all of the [DVC metafiles and | |
| directories][dvc-metafiles] -- <abbr>cache</abbr>, `dvc.yaml`, `.dvc` files, | |
| etc. Any other files referenced from these DVC metafiles are also considered | |
| part of the project (e.g. [metrics files](/doc/command-reference/metrics)). |
There was a problem hiding this comment.
Thanks for the suggestion but I think both are valid since this text is right under the DVC Project title (so that's clearly what "it" refers to, I think). Stylistic
There was a problem hiding this comment.
Oh I see there's another copy edit that changes `"including" for long dash. Same thing though, both are valid I think. I incline to keep mine of course unless there's an error somewhere.
There was a problem hiding this comment.
| Initialized by running `dvc init` in you <abbr>workspace</abbr> directory, it | |
| will contain all the [DVC files and directories][dvc-metafiles] including the | |
| <abbr>cache</abbr>, `dvc.yaml` and `.dvc` files, etc. Any other files referenced | |
| from these DVC metafiles are also considered part of the project (for example | |
| [metrics files](/doc/command-reference/metrics)). | |
| Initialized by running `dvc init` in your <abbr>workspace</abbr> directory, a | |
| DVC project will contain all of the [DVC metafiles and | |
| directories][dvc-metafiles], such as the <abbr>cache</abbr>, `dvc.yaml`, and | |
| `.dvc` files. Any other files referenced from these DVC metafiles are also | |
| considered part of the project (e.g. [metrics | |
| files](/doc/command-reference/metrics)). |
lots of typos as well. compromised.
| A DVC project in a Git repository can also be called _DVC repository_ or "the | ||
| repo". This setup enables the | ||
| [versioning features](/doc/start/data-and-model-versioning) of DVC | ||
| (recommended). Files tracked by Git are considered part of the DVC project when | ||
| referenced from DVC metafiles such as `dvc.lock`, for example source code that | ||
| is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`). |
There was a problem hiding this comment.
| A DVC project in a Git repository can also be called _DVC repository_ or "the | |
| repo". This setup enables the | |
| [versioning features](/doc/start/data-and-model-versioning) of DVC | |
| (recommended). Files tracked by Git are considered part of the DVC project when | |
| referenced from DVC metafiles such as `dvc.lock`, for example source code that | |
| is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`). | |
| A DVC project in a Git repository can also be called a _DVC repository_ or "the | |
| repo". This setup enables the | |
| [versioning features](/doc/start/data-and-model-versioning) of DVC | |
| (recommended). Files tracked by Git are considered part of the DVC project when | |
| referenced from DVC metafiles such as `dvc.lock` -- e.g. source code that is | |
| used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`). |
There was a problem hiding this comment.
Again thanks but I prefer , for example. It's simpler and hopefully easier to read.
There was a problem hiding this comment.
| A DVC project in a Git repository can also be called _DVC repository_ or "the | |
| repo". This setup enables the | |
| [versioning features](/doc/start/data-and-model-versioning) of DVC | |
| (recommended). Files tracked by Git are considered part of the DVC project when | |
| referenced from DVC metafiles such as `dvc.lock`, for example source code that | |
| is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`). | |
| A DVC project in a Git repository can also be called a _DVC repository_ or "the | |
| repo". This setup enables the | |
| [versioning features](/doc/start/data-and-model-versioning) of DVC | |
| (recommended). Files tracked by Git are considered part of the DVC project when | |
| referenced from DVC metafiles such as `dvc.lock`; for example source code that | |
| is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`). |
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
51200ca to
4f62edc
Compare
|
|
||
| Initialized by running `dvc init` in your <abbr>workspace</abbr> directory, a | ||
| DVC project will contain all of the [DVC metafiles and | ||
| directories][dvc-metafiles], such as the <abbr>cache</abbr>, `dvc.yaml`, and |
There was a problem hiding this comment.
cache location can be changed though
There was a problem hiding this comment.
yes, but explicitly stating that here may seem tangential/distract from the point? I don't have strong opinions here. The <abbr/> tooltip will of course provide more details.
There was a problem hiding this comment.
cache location can be changed
"such as" leaves room for that.
|
The changes in 4f62edc are completely stylistic. Please don't overwrite/force push over team members work without a good reason when reviewing @casperdcl . We only take over contributions from other teams or external (or if agreed). |
and
not so. you -> your, called DVC repo -> called a DVC repo. Reverted the emdash which you requested removed. |
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
Per #550 epic