Skip to content

guide: DVC Project concept page#2754

Merged
casperdcl merged 7 commits into
masterfrom
guide/concepts/project
Aug 31, 2021
Merged

guide: DVC Project concept page#2754
casperdcl merged 7 commits into
masterfrom
guide/concepts/project

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

Per #550 epic

@shcheklein shcheklein temporarily deployed to dvc-org-guide-concepts--pbhe3l August 25, 2021 01:33 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Aug 25, 2021
14 tasks
@jorgeorpinel jorgeorpinel self-assigned this Aug 25, 2021
@jorgeorpinel jorgeorpinel marked this pull request as ready for review August 25, 2021 03:13
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-concepts--pbhe3l August 25, 2021 03:13 Inactive
@jorgeorpinel jorgeorpinel requested a review from casperdcl August 25, 2021 03:14
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-concepts--pbhe3l August 25, 2021 03:14 Inactive
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Would appreciate a quick review @casperdcl 🙏

Comment thread content/docs/user-guide/basic-concepts/dvc-project.md
repository). It will contain the `.dvc/` directory, as well as `dvc.yaml` and
`.dvc` files created with commands such as `dvc add` or `dvc run`.
`.dvc` files created with commands such as `dvc add` or `dvc run`.
See [full concept](/doc/user-guide/basic-concepts/dvc-project).

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

@jorgeorpinel jorgeorpinel Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-render if markdown (below) is non-empty?

Yes it was mentioned in #2453 (review) (well sort of -- auto-linking from Glossary) and discussed with the team but deemed not a priority (at all). Also related to #2755 (review)

Copy link
Copy Markdown
Contributor Author

@jorgeorpinel jorgeorpinel Aug 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. created #2771

p.p.s. I did apply the suggestion in this review.

Comment on lines +23 to +27
Initialized by running `dvc init` in you <abbr>workspace</abbr> directory, it
will contain all the [DVC files and directories][dvc-metafiles] including the
<abbr>cache</abbr>, `dvc.yaml` and `.dvc` files, etc. Any other files referenced
from these DVC metafiles are also considered part of the project (for example
[metrics files](/doc/command-reference/metrics)).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Initialized by running `dvc init` in you <abbr>workspace</abbr> directory, it
will contain all the [DVC files and directories][dvc-metafiles] including the
<abbr>cache</abbr>, `dvc.yaml` and `.dvc` files, etc. Any other files referenced
from these DVC metafiles are also considered part of the project (for example
[metrics files](/doc/command-reference/metrics)).
Initialized by running `dvc init` in your <abbr>workspace</abbr> directory, a
DVC project will contain all of the [DVC metafiles and
directories][dvc-metafiles] -- <abbr>cache</abbr>, `dvc.yaml`, `.dvc` files,
etc. Any other files referenced from these DVC metafiles are also considered
part of the project (e.g. [metrics files](/doc/command-reference/metrics)).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion but I think both are valid since this text is right under the DVC Project title (so that's clearly what "it" refers to, I think). Stylistic

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see there's another copy edit that changes `"including" for long dash. Same thing though, both are valid I think. I incline to keep mine of course unless there's an error somewhere.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Initialized by running `dvc init` in you <abbr>workspace</abbr> directory, it
will contain all the [DVC files and directories][dvc-metafiles] including the
<abbr>cache</abbr>, `dvc.yaml` and `.dvc` files, etc. Any other files referenced
from these DVC metafiles are also considered part of the project (for example
[metrics files](/doc/command-reference/metrics)).
Initialized by running `dvc init` in your <abbr>workspace</abbr> directory, a
DVC project will contain all of the [DVC metafiles and
directories][dvc-metafiles], such as the <abbr>cache</abbr>, `dvc.yaml`, and
`.dvc` files. Any other files referenced from these DVC metafiles are also
considered part of the project (e.g. [metrics
files](/doc/command-reference/metrics)).

lots of typos as well. compromised.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What typos?

Comment on lines +36 to +41
A DVC project in a Git repository can also be called _DVC repository_ or "the
repo". This setup enables the
[versioning features](/doc/start/data-and-model-versioning) of DVC
(recommended). Files tracked by Git are considered part of the DVC project when
referenced from DVC metafiles such as `dvc.lock`, for example source code that
is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A DVC project in a Git repository can also be called _DVC repository_ or "the
repo". This setup enables the
[versioning features](/doc/start/data-and-model-versioning) of DVC
(recommended). Files tracked by Git are considered part of the DVC project when
referenced from DVC metafiles such as `dvc.lock`, for example source code that
is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`).
A DVC project in a Git repository can also be called a _DVC repository_ or "the
repo". This setup enables the
[versioning features](/doc/start/data-and-model-versioning) of DVC
(recommended). Files tracked by Git are considered part of the DVC project when
referenced from DVC metafiles such as `dvc.lock` -- e.g. source code that is
used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again thanks but I prefer , for example. It's simpler and hopefully easier to read.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A DVC project in a Git repository can also be called _DVC repository_ or "the
repo". This setup enables the
[versioning features](/doc/start/data-and-model-versioning) of DVC
(recommended). Files tracked by Git are considered part of the DVC project when
referenced from DVC metafiles such as `dvc.lock`, for example source code that
is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`).
A DVC project in a Git repository can also be called a _DVC repository_ or "the
repo". This setup enables the
[versioning features](/doc/start/data-and-model-versioning) of DVC
(recommended). Files tracked by Git are considered part of the DVC project when
referenced from DVC metafiles such as `dvc.lock`; for example source code that
is used as a <abbr>stage</abbr> command (`cmd` field in `dvc.yaml`).

@casperdcl casperdcl added the A: docs Area: user documentation (gatsby-theme-iterative) label Aug 25, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-concepts--pbhe3l August 31, 2021 07:48 Inactive
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-concepts--pbhe3l August 31, 2021 07:57 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-guide-concepts--pbhe3l August 31, 2021 07:58 Inactive
@jorgeorpinel jorgeorpinel requested a review from casperdcl August 31, 2021 08:05
@shcheklein shcheklein temporarily deployed to dvc-org-guide-concepts--pbhe3l August 31, 2021 11:14 Inactive
@casperdcl casperdcl force-pushed the guide/concepts/project branch from 51200ca to 4f62edc Compare August 31, 2021 11:18
@shcheklein shcheklein temporarily deployed to dvc-org-guide-concepts--pbhe3l August 31, 2021 11:18 Inactive

Initialized by running `dvc init` in your <abbr>workspace</abbr> directory, a
DVC project will contain all of the [DVC metafiles and
directories][dvc-metafiles], such as the <abbr>cache</abbr>, `dvc.yaml`, and
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache location can be changed though

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but explicitly stating that here may seem tangential/distract from the point? I don't have strong opinions here. The <abbr/> tooltip will of course provide more details.

Copy link
Copy Markdown
Contributor Author

@jorgeorpinel jorgeorpinel Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache location can be changed

"such as" leaves room for that.

@casperdcl casperdcl merged commit 5d4b5a1 into master Aug 31, 2021
@casperdcl casperdcl deleted the guide/concepts/project branch August 31, 2021 18:39
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

jorgeorpinel commented Sep 1, 2021

The changes in 4f62edc are completely stylistic. Please don't overwrite/force push over team members work without a good reason when reviewing @casperdcl . We only take over contributions from other teams or external (or if agreed).

@casperdcl
Copy link
Copy Markdown
Contributor

What typos?

and

The changes in 4f62edc are completely stylistic

not so. you -> your, called DVC repo -> called a DVC repo. Reverted the emdash which you requested removed.

karajan1001 pushed a commit to karajan1001/dvc.org that referenced this pull request Sep 29, 2021
Co-authored-by: Casper da Costa-Luis <casper.dcl@physics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: docs Area: user documentation (gatsby-theme-iterative)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants