exp push/pull: add --rev, -n, -A flags#3192
Merged
Merged
Conversation
iesahin
added
the
⌛ status: wait-core-merge
karajan1001
force-pushed
the
modify_exp_push_pull
branch
2 times, most recently
from
2858ef3 to
2276358
Compare
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
changed the title
--rev, -n, -A flag exp pull/pushexp push/pull: add --rev, -n, -A flags
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
These will need an update again once #3187 (review) is resolved 🙂
related to treeverse/dvc#7255 Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
karajan1001
force-pushed
the
modify_exp_push_pull
branch
from
c02100c to
4010675
Compare
jorgeorpinel
reviewed
Mar 8, 2022
jorgeorpinel
reviewed
Mar 8, 2022
jorgeorpinel
reviewed
Mar 9, 2022
jorgeorpinel
reviewed
Mar 9, 2022
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
jorgeorpinel
removed
the
⌛ status: wait-core-merge
Comment on lines
+9
to
+15
| usage: dvc exp pull [-h] [-q | -v] [-A] [--rev <commit>] [-n <num>] [-f] | ||
| [--no-cache] [-r <name>] [-j <number>] [--run-cache] | ||
| git_remote experiment | ||
|
|
||
| positional arguments: | ||
| git_remote Git remote name or Git URL | ||
| experiment Experiment to pull | ||
| experiment Experiments to pull |
Contributor
There was a problem hiding this comment.
If it accepts multiple experiments, shouldn't the usage block look different?
Contributor
Author
There was a problem hiding this comment.
related to #3340?
Excuse me, do you mean
usage: dvc exp pull [-h] [-q | -v] [-A] [--rev <commit>] [-n <num>] [-f]
[--no-cache] [-r <name>] [-j <number>] [--run-cache]
git_remote experiments
or
usage: dvc exp pull [-h] [-q | -v] [-A] [--rev <commit>] [-n <num>] [-f]
[--no-cache] [-r <name>] [-j <number>] [--run-cache]
git_remote experiment1 experiment2 experiment3 ...
If the first one, we also need some modifications on the core repo side. If the second, this usage is generated by the argparse's help message in dvc exp pull --help.
Contributor
There was a problem hiding this comment.
This is what I get for dvc exp pull --help:
usage: dvc experiments pull [-h] [-q | -v] [-A] [--rev <commit>] [-n <num>] [-f]
[--no-cache] [-r <name>] [-j <number>] [--run-cache]
<git_remote> [<experiment> ...]
Pull an experiment from a Git remote.
Documentation: <https://man.dvc.org/exp/pull>
positional arguments:
<git_remote> Git remote name or Git URL.
<experiment> Experiments to pull.
Is there any reason we wouldn't use that? Are others not seeing the same?
Contributor
There was a problem hiding this comment.
Yes what you see is what I meant @dberenbaum , specifically the line
<git_remote> [<experiment> ...]
But if this is part of #3340 and other refs need to be updated as well, maybe don't include the change here at all @karajan1001 . Thanks
Comment on lines
+9
to
+15
| usage: dvc exp push [-h] [-q | -v] [-A] [--rev <commit>] [-n <num>] [-f] | ||
| [--no-cache] [-r <name>] [-j <number>] [--run-cache] | ||
| git_remote experiment | ||
|
|
||
| positional arguments: | ||
| git_remote Git remote name or Git URL | ||
| experiment Experiment to push | ||
| experiment Experiments to push |
Contributor
Author
There was a problem hiding this comment.
Also change line 11 to git_remote [experiment [experiment ...]]?
Contributor
There was a problem hiding this comment.
Idk, can we discuss that in a separate PR? Ideally in the core PR related to this. Thanks
2 tasks
jorgeorpinel
reviewed
Apr 3, 2022
jorgeorpinel
reviewed
Apr 3, 2022
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to treeverse/dvc#7255