`exp show`: add `--rev` option by karajan1001 · Pull Request #3187 · treeverse/dvc.org

karajan1001 · 2022-01-17T10:53:50Z

& treeverse/dvc#7245

jorgeorpinel

Based on texts discussed in https://github.com/iterative/dvc/pull/7245/files

jorgeorpinel · 2022-01-27T04:23:02Z

@karajan1001 please remember to use branches directly on this repo instead of your repo fork so the PRs are automatically deployed to review apps, and so maintainers can commit suggestions. Maybe delete your fork to avoid future confusion? Thanks

jorgeorpinel · 2022-01-28T04:18:24Z

OK so I approved #3228 which is a correctly formatted version of this PR. But I'm not sure we want to merge it yet.

Is the --num <num> behavior where -1 is accepted going to be released or revisited? Thanks

In reference to discussion currently under #3191 (review)

karajan1001 · 2022-01-28T10:36:04Z

#3228

We can wait until -1 has been decided.

jorgeorpinel · 2022-02-02T01:49:18Z

Looks like there's an even deeper question around -n. See treeverse/dvc#7245 (review)

If you don't mind merging branch restyled/add_rev_to_exp_show into here for now, that would be great. Thanks @karajan1001

jorgeorpinel · 2022-03-08T05:16:45Z

+- `-n <num>`, `--num <num>` - show experiments from the previous `num` commits
+  (before the `--rev` baseline). For example `-n -2` includes experiments from
+  `HEAD` and its 2 first ancestors.


The info about negative values seems wrong here after all (sorry I was confused). The text should be closer to treeverse/dvc#7245 (review), right? Please double check the suggestion, thanks!

Suggested change

- `-n <num>`, `--num <num>` - show experiments from the previous `num` commits

(before the `--rev` baseline). For example `-n -2` includes experiments from

`HEAD` and its 2 first ancestors.

- `-n <num>`, `--num <num>` - show experiments from the `--rev` baseline and

from `num` commits before it (first parents). Give a negative value to include

all first-parent commits (similar to `git log -n`).

But TBH I'm not sure why this is being changed here if there's no change for --num in the related core PR, treeverse/dvc#7204 🤷🏼

Does this PR also depend on treeverse/dvc#7245 ? Marked as waiting for core merge for now.

But TBH I'm not sure why this is being changed here if there's no change for --num in the related core PR, iterative/dvc#7204 🤷🏼

I just forgot to update the doc in treeverse/dvc#7204.

iesahin · 2022-03-08T14:39:22Z

Both of the dependency PRs seem to be merged, could we merge this now? @karajan1001

1. add a new flag `--rev` to `dvc exp show` command. related to treeverse/dvc#7204 Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Dave Berenbaum <dave.berenbaum@gmail.com>

jorgeorpinel

Thanks @karajan1001 @dberenbaum

jorgeorpinel · 2022-03-09T07:43:19Z

Please merge when you think it's appropriate @karajan1001 @dberenbaum (guessing the feature isn't released yet).

fix: treeverse#7444 from the discussion treeverse/dvc.org#3187 (comment) 1. Update the help message of `-n`

karajan1001 · 2022-03-10T07:19:13Z

You’re not authorized to merge this pull request.
Looks like I can't merge it myself @jorgeorpinel

fix: #7444 from the discussion treeverse/dvc.org#3187 (comment) 1. Update the help message of `-n`

1. add a new flag `--rev` to `dvc exp show` command. related to treeverse/dvc#7204 Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Dave Berenbaum <dave.berenbaum@gmail.com> Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Dave Berenbaum <dave.berenbaum@gmail.com>

karajan1001 requested a review from jorgeorpinel January 17, 2022 10:53

karajan1001 force-pushed the add_rev_to_exp_show branch from 91e2736 to a79c375 Compare January 17, 2022 10:58

karajan1001 marked this pull request as draft January 17, 2022 11:36

karajan1001 force-pushed the add_rev_to_exp_show branch from a79c375 to fb69d23 Compare January 18, 2022 08:09

karajan1001 marked this pull request as ready for review January 18, 2022 08:10

iesahin reviewed Jan 19, 2022

View reviewed changes

Comment thread content/docs/command-reference/exp/show.md Outdated

iesahin added C: ref Content of /doc/*-reference ⌛ status: wait-core-merge Waiting for related product PR merge/release labels Jan 19, 2022

shcheklein removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Jan 19, 2022

karajan1001 force-pushed the add_rev_to_exp_show branch from fb69d23 to 76e9129 Compare January 24, 2022 08:23

jorgeorpinel suggested changes Jan 27, 2022

View reviewed changes

Comment thread content/docs/command-reference/exp/show.md Outdated

Comment thread content/docs/command-reference/exp/show.md Outdated

jorgeorpinel temporarily deployed to dvc-org-add-rev-to-exp--lvneuz January 27, 2022 04:23 Inactive

jorgeorpinel assigned karajan1001 Jan 27, 2022

This was referenced Jan 27, 2022

exp push/pull: add --rev, -n, -A flags #3192

Merged

exp remove: add --rev and -n options #3193

Merged

jorgeorpinel changed the title ~~exp show: add --rev flag exp show~~ exp show: add --rev option Jan 27, 2022

jorgeorpinel mentioned this pull request Jan 27, 2022

exp list: add --num option, rename --all to --all-commits #3191

Merged

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz January 27, 2022 11:16 Inactive

restyled-io Bot mentioned this pull request Jan 27, 2022

Restyle exp show: add --rev option #3228

Closed

This comment was marked as resolved.

Sign in to view

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz February 4, 2022 02:45 Inactive

jorgeorpinel reviewed Feb 16, 2022

View reviewed changes

Comment thread content/docs/command-reference/exp/show.md Outdated

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz February 16, 2022 03:58 Inactive

jorgeorpinel reviewed Feb 16, 2022

View reviewed changes

Comment thread content/docs/command-reference/exp/show.md Outdated

karajan1001 force-pushed the add_rev_to_exp_show branch from 0f63876 to b862f68 Compare February 16, 2022 07:23

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz February 16, 2022 07:23 Inactive

karajan1001 force-pushed the add_rev_to_exp_show branch from b862f68 to 230cd03 Compare February 16, 2022 07:29

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz February 16, 2022 07:29 Inactive

karajan1001 force-pushed the add_rev_to_exp_show branch from 230cd03 to 0eed2c1 Compare February 16, 2022 07:33

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz February 16, 2022 07:33 Inactive

jorgeorpinel mentioned this pull request Mar 8, 2022

exp remove: rename --all-commits flag add a new rev flag and unify the collection of revs (#7155) treeverse/dvc#7275

Merged

2 tasks

jorgeorpinel reviewed Mar 8, 2022

View reviewed changes

jorgeorpinel approved these changes Mar 8, 2022

View reviewed changes

jorgeorpinel added the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Mar 8, 2022

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz March 8, 2022 07:14 Inactive

daavoo removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Mar 8, 2022

dberenbaum mentioned this pull request Mar 8, 2022

exp show/list: help text for -n treeverse/dvc#7444

Closed

dberenbaum reviewed Mar 8, 2022

View reviewed changes

Comment thread content/docs/command-reference/exp/show.md Outdated

restyled-io Bot mentioned this pull request Mar 9, 2022

Restyle exp show: add --rev option #3341

Closed

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz March 9, 2022 03:04 Inactive

exp show: add --rev flag exp show

06ba918

1. add a new flag `--rev` to `dvc exp show` command. related to treeverse/dvc#7204 Co-authored-by: Jorge Orpinel <jorgeorpinel@users.noreply.github.com> Co-authored-by: Dave Berenbaum <dave.berenbaum@gmail.com>

karajan1001 force-pushed the add_rev_to_exp_show branch from 0263218 to 06ba918 Compare March 9, 2022 03:13

shcheklein temporarily deployed to dvc-org-add-rev-to-exp--lvneuz March 9, 2022 03:13 Inactive

jorgeorpinel approved these changes Mar 9, 2022

View reviewed changes

jorgeorpinel removed the C: ref Content of /doc/*-reference label Mar 9, 2022

karajan1001 added a commit to karajan1001/dvc that referenced this pull request Mar 10, 2022

exp show/pull/push/list: help text for -n (treeverse#7444)

05fc022

fix: treeverse#7444 from the discussion treeverse/dvc.org#3187 (comment) 1. Update the help message of `-n`

karajan1001 mentioned this pull request Mar 10, 2022

exp show/pull/push/list: help text for -n (#7444) treeverse/dvc#7450

Merged

2 tasks

jorgeorpinel merged commit a6fc0fb into treeverse:master Mar 10, 2022

karajan1001 added a commit to treeverse/dvc that referenced this pull request Mar 10, 2022

exp show/pull/push/list: help text for -n (#7444)

6a6955e

fix: #7444 from the discussion treeverse/dvc.org#3187 (comment) 1. Update the help message of `-n`

karajan1001 deleted the add_rev_to_exp_show branch March 10, 2022 09:12

Conversation

karajan1001 commented Jan 17, 2022 • edited by jorgeorpinel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jorgeorpinel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jorgeorpinel commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jorgeorpinel commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karajan1001 commented Jan 28, 2022

Uh oh!

jorgeorpinel commented Feb 2, 2022

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

Uh oh!

jorgeorpinel Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karajan1001 Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

iesahin commented Mar 8, 2022

Uh oh!

Uh oh!

jorgeorpinel left a comment

Choose a reason for hiding this comment

Uh oh!

jorgeorpinel commented Mar 9, 2022

Uh oh!

karajan1001 commented Mar 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

karajan1001 commented Jan 17, 2022 •

edited by jorgeorpinel

Loading

jorgeorpinel commented Jan 27, 2022 •

edited

Loading

jorgeorpinel commented Jan 28, 2022 •

edited

Loading

jorgeorpinel Mar 8, 2022 •

edited

Loading

jorgeorpinel Mar 8, 2022 •

edited

Loading