-
Notifications
You must be signed in to change notification settings - Fork 406
Automate updating of exp show tables
#3219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ├── 6d13f33 [cnn-64] Sep 09, 2021 0.23385 0.9153 10 64 | ||
| ├── 69503c6 [cnn-128] Sep 09, 2021 0.23243 0.916 10 128 | ||
| ─────────────────────────────────────────────────────────────────────────────────────────── | ||
| $dvc-experiments-exp-show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, if we're to check in this line to Git, we'll need to run the script to populate the tables, right? My "creating a dependency" comment is about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual table that replaces each of these placeholders (${X}) is also committed in Git (https://github.com/iterative/dvc.org/blob/083f0655b98bfb193a1fd96e00a4cb256328af9e/plugins/gatsby-remark-dvctable-filler/tables.js).
There is no need to run the script, yarn develop will replace the placeholder with the corresponding table content.
What changes to the core |
Any change that updates the output or the style of the table generated by For example, treeverse/dvc#7089 adds the new type of columns affecting practically all tables. If I had to send the doc updates without the script and plugin added in this P.R., I would have to manually review the existing tables and, for each one:
With this P.R. I just run the |
|
It looks this creates a dependency to DVC in I have a more general However, I'm not fully comfortable to depend DVC for the site. |
Given that this doesn't run automatically, I don't fully understand how this creates a dependency if I would be basically doing the same as the script and manually copy pasting to the md files.
I have seen that (and like 👍 ) but didn't work exactly as I intended for the tables so I added the plugin |
|
Being able to generate code blocks for table output is a good idea, and I think the loose dependency on dvc isn't a dealbreaker, but this PR does exceed my threshold for acceptable hackiness a bit- particularly how new tables have to be added in the middle of a Python source file and not even its own dedicated config file. I think the website and docs teams can collaborate to add a but more polished implementation of this feature if we deem it important enough. |
Agreeing with @rogermparent, this might be too hacky, even for a first iteration. 🤔 Also if we decide to do something like this, whether by merging this pr or coming up with a different implementation later, we'll probably need to document how it works and what you need to run the script. |
|
@rogermparent , @julieg18 I totally agree with you. I just wanted to try to push a little bit the discussion about automating the generation of some parts of the docs. In the case of the However, I don't want this hacky stuff to generate additional unplanned work for the websites team. Maybe we can push back this P.R. and bring back the discussion in #2770 (I will continue using hacky script locally but sent the final rendered results on P.R. so it would be just markdown updates) |
|
I like the idea and I really appreciate the amount of effort @daavoo put into this! Let's try to collaborate and get to the state we all want it to be if agree on the approach. Just to clarify the benefits (if we fix all these small things here and there) of the approach:
regarding the last point - how does it actually happen? do we run an actual DVC command in the repo or we can just copy paste the output? any other things I'm missing? cons that I see so far:
anything else? |
We should definitely continue to discuss and work on this! #2770 seems to be more focused on autogenerating the markdown for the Options/Synopsis sections. @daavoo, should we open a separate issue for discussing autogenerating tables or discuss both from there? |
Added a hacky script and plugin for updating tables in order to reflect changes to the core
dvc exp show.What I do locally to update all tables to reflect the latest
dvcchanges is:And update
scripts/create_dvctables.pyif I need to add a new table.