Dvc exp show deps #3220
Dvc exp show deps #3220
Conversation
daavoo
force-pushed
the
dvc-exp-show-deps
branch
from
3447147 to
2d73993
Compare
|
Looks like a change with a big impact on existing docs... @daavoo you can scope these to cmd ref only 🙂 We can make issues to update Get Started and Guides later if needed; It may involve discussing so it's OK if that takes longer and falls on docs team. But if you think the work so far on those should be reviewed, lmk (we may just need to extract that to 1+ separate PRs). |
|
And another scope-related Q: is it too much to cover treeverse/dvc#7089 as well as #3202 and #3211 in a single PR? Maybe the latter 2 should be worked on first/separately. |
I' ve already included updates for Get Started and 1 of the tables in the user guide. I'll open an issue for the user guide updates.
Extracted #3237 |
| and params from the entire project. The `--only-changed`, `--drop`, `--keep`, | ||
| and other [options](#options) can determine which ones should be displayed. | ||
| By default, the printed experiments table will include columns for all | ||
| dependencies, metrics and params from the entire project. The `--only-changed`, |
There was a problem hiding this comment.
In general, should we order in the same way they appear (metrics, params, deps) throughout the docs?
There was a problem hiding this comment.
I changed the order.
I have also noticed that params and parameters are used arbitrarily.
Should we consolidate params / deps or the longer version? cc @jorgeorpinel
There was a problem hiding this comment.
I usually prefer the longer versions thinking they are more likely to be searched.
There was a problem hiding this comment.
Replaced all occurrences with long version
iesahin
left a comment
iesahin
left a comment
There was a problem hiding this comment.
Looks good to me but I'll wait for @jorgeorpinel 's review before merge.
You and @dberenbaum take this one please. I got a few other ones. My initial concerns were addressed. Thanks |
content/docs/user-guide/experiment-management/comparing-experiments.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/experiment-management/comparing-experiments.md
Outdated
Show resolved
Hide resolved
content/docs/user-guide/experiment-management/comparing-experiments.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dave Berenbaum <dave@iterative.ai>
Co-authored-by: Restyled.io <commits@restyled.io>
* dvctable: Add `violet` for `dep` columns. * Add dep columns in `exp show` ref. * Mention dependencies in start and user-guide. * Update table * Update tables in get started. * Mention column order * Order metrics, params and dependencies. * Replace params with parameters * Remove dvctables * Apply suggestions from code review Co-authored-by: Dave Berenbaum <dave@iterative.ai> * Restyled by prettier (#3254) Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Dave Berenbaum <dave@iterative.ai> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
5 participants
P.R. for treeverse/dvc#7089
Closes #3211