Introduce dvc commit#1601
Conversation
efiop
force-pushed
the
919
branch
2 times, most recently
from
a8c7ad1 to
8f6d4ef
Compare
efiop
force-pushed
the
919
branch
2 times, most recently
from
19231d6 to
70453de
Compare
Related to treeverse/dvc#1601 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
There was a problem hiding this comment.
can dvc commit change stage files?
There was a problem hiding this comment.
Yes. It will re-calculate checksums if they are missing or they don't match(this one only if explicitly confirmed with a prompt or --force flag).
There was a problem hiding this comment.
It makes sense. How about this case then. In the next version we are going o have no-commit enabled by default, right? So, let's imagine I run something in master and then checkout another branch. It means that checksums in stage files are wrong now. But is does not mean that I want force them when I run dvc commit, all I want to do is to save files to cache. It might be that we'll need to abort the checkout itself, similar to what git is doing, right? Any thoughts on this? Basically, I'm thinking is it always the case that we want to force the change in stage files or do we just want to push data (e.g. generated in a different branch, or previous git commit, or whatnot) to cache.
There was a problem hiding this comment.
That's a great point! We need to have that check on dvc checkout. Looking into it...
There was a problem hiding this comment.
@shcheklein Just checked and we do check that on dvc checkout anyway. E.g. not committed stage.dvc means that there is no cache for it and so dvc checkout will prompt user asking file 'foo' is going to be removed. Are you sure you want to proceed? So we are covered there. Still, the message is not very informative, so I'll add a clarification for it.
There was a problem hiding this comment.
For the record:created #1622 for it for now.
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Good stuff. More questions than fixes or improvements.
efiop
force-pushed
the
919
branch
2 times, most recently
from
e7494a1 to
d2281ad
Compare
dmpetrov
left a comment
dmpetrov
left a comment
There was a problem hiding this comment.
Great change! dvc will have commit finaly 🎉
Just a couple questions inline...
dmpetrov
left a comment
dmpetrov
left a comment
There was a problem hiding this comment.
Great change! 🥇
Please take a look at this comment: #1403 (comment)
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Related to treeverse/dvc#1601 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
|
This is a great addition!! I found |
|
@colllin glad you found it useful! Thank you for the feedback! 🙂 |
4 participants
Fixes #919