Skip to content

Force commit action by default#3726

Merged
mattseddon merged 2 commits into
mainfrom
force-commit
Apr 20, 2023
Merged

Force commit action by default#3726
mattseddon merged 2 commits into
mainfrom
force-commit

Conversation

@mattseddon
Copy link
Copy Markdown
Contributor

@mattseddon mattseddon commented Apr 20, 2023

This PR add -f to all of our calls to dvc commit. This change is based on #3286 (comment)

dvc commit is one of the few commands that's interactive by default and always asks "Are you sure you want to commit?" if there are changes. TBH I'm not sure it's necessary at this point (looks like it is very old, see treeverse/dvc#1601). IMO for VS Code we should do dvc commit -f by default here.

@mattseddon mattseddon added the bug Something isn't working label Apr 20, 2023
@mattseddon mattseddon self-assigned this Apr 20, 2023
@mattseddon mattseddon marked this pull request as ready for review April 20, 2023 04:34
Copy link
Copy Markdown
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon enabled auto-merge (squash) April 20, 2023 20:47
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 925363b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 94.8% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit dcbded5 into main Apr 20, 2023
@mattseddon mattseddon deleted the force-commit branch April 20, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants