run/repro: rename "build cache" -> "run cache"#3788
Merged
Conversation
shcheklein
reviewed
May 12, 2020
Contributor
|
update zsh/bash? update help if needed? |
efiop
changed the title
efiop
force-pushed
the
1234
branch
2 times, most recently
from
0c423ee to
913ba7e
Compare
efiop
pushed a commit
to treeverse/dvc.org
that referenced
this pull request
May 12, 2020
efiop
changed the title
efiop
commented
May 12, 2020
efiop
pushed a commit
to treeverse/dvc.org
that referenced
this pull request
May 12, 2020
Contributor
|
Look good overall (from the naming perspective, was not reviewing specific impl details). Just a minor comment. |
efiop
pushed a commit
to treeverse/dvc.org
that referenced
this pull request
May 13, 2020
shcheklein
pushed a commit
to treeverse/dvc.org
that referenced
this pull request
May 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
--ignore-build-cachewe now have--no-run-cachefor run/repro which disables our actual run-cache and--force-downstreamforreprothat better describes the old behaviour.Part of #3777
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
docs: --ignore-build-cache -> --no-run-cache dvc.org#1285
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏