fs: make constructor closer to fsspec#5911
Merged
Merged
Conversation
efiop
commented
May 3, 2021
Contributor
Author
There was a problem hiding this comment.
Need to start using kwargs, this is unwieldy already.
efiop
commented
May 3, 2021
Comment on lines
91
to
105
Contributor
Author
There was a problem hiding this comment.
These config options would fit nicely into a dynamic config schema, if we had one. Will take a look...
efiop
force-pushed
the
remove_repo_from_fs
branch
9 times, most recently
from
5dbe6af to
b15200a
Compare
efiop
commented
May 12, 2021
efiop
force-pushed
the
remove_repo_from_fs
branch
from
be89d67 to
5ea6276
Compare
efiop
changed the title
efiop
added
refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo:
* [ ] get rid of fs.path_info(will be a followup, need to get rid of fs_root first).Depends on: #5683 and #5812 , will rebase when those are merged.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏