Remove all uses of selector & to support nested import?#17352
Closed
Remove all uses of selector & to support nested import?#17352
selector & to support nested import?#17352Conversation
If we want to support namespaced import:
.twbs {
@import 'bootstrap';
}
We cannot use `selector &`, see sass/sass#1817.
This is one ugly workaround, but it works.
Requires libsass 3.3 which has not been released yet (but soon hopefully).
Collaborator
|
Ugh. I still think CSS postprocessing is the better way to do that. This pass-the-selector-as-a-string business is whack. |
Member
Author
|
So.. I just tried disabling a fieldset, and all its children automatically become |
Member
Author
|
Closing, opened #17364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See sass/sass#1817 for the context on this.
If we want to support namespaced import, i.e.:
We cannot use
selector &, see sass/sass#1817.This is one ugly workaround, but it works.
Requires libsass 3.3 (due to
selector-unifyandselector-nest) which has not been released yet (but soon hopefully), so travis will fail.