Remove all uses of selector & to support nested import#17364
Conversation
If we want to support namespaced import:
```scss
.twbs {
@import 'bootstrap';
}
```
We cannot use `selector &`, see sass/sass#1817.
`fieldset[disabled] &` is not needed as we no longer support IE8.
selector &selector & to support nested import
|
That is a very important decision! Thank you so much, I thought we're the only one namespacing our bootstrap. |
|
👍 |
|
I'm totally in favor of removing As for the general point, until Sass adds some feature (or folks discover some idiom/workaround) to aid that sort of prefixing, I think CSS postprocessing is still the way to go for that. |
|
We already do other things to support nested import, e.g. see https://github.com/twbs/bootstrap/blob/v4-dev/scss/_reboot.scss#L46, this is the only other change required as far as I can tell. |
|
If future versions need to use |
|
|
Remove all uses of `selector &` to support nested import
If we want to support namespaced import:
We cannot use
selector &, see sass/sass#1817.fieldset[disabled] &is not needed as we no longer support IE8.