Dismissable alert close button padding#24478
Dismissable alert close button padding#24478MattJLeach wants to merge 1 commit intotwbs:v4-devfrom MattJLeach:v4-dev
Conversation
|
Hi @MattJLeach Thanks a lot for trying to fix this. The solution you are proposing adds a huge padding on the left or the alert. I don't think this is valid solution. |
|
Would you prefer to have increased padding on the right and keep the left the same as it is now @andresgalante ? The only reason I increased both was to keep the text in the centre. |
|
@MattJLeach I think the padding should go on the parent, not on the close icon, as I describe here #24469 |
|
Hi @MattJLeach, I am going to close this PR in favor of #24481 Thanks a lot for taking the time to make a contribution |
|
Sounds good @andresgalante. Thanks for the feedback on my PR. I'll keep an eye out for any other issues I can help with but comment and discuss before doing an actual PR first. |
|
Thanks man, feel free to send as many PRs as you can, it'll be my pleasure to review them. |
I have increased the y padding for the alert and made the padding for the close button the same all round.
Fixes #24469