Skip to content

Fix for right padding in dismissible alerts#24481

Merged
mdo merged 4 commits intotwbs:v4-devfrom
Kopyov:alert-padding-fix
Oct 22, 2017
Merged

Fix for right padding in dismissible alerts#24481
mdo merged 4 commits intotwbs:v4-devfrom
Kopyov:alert-padding-fix

Conversation

@Kopyov
Copy link
Copy Markdown
Contributor

@Kopyov Kopyov commented Oct 20, 2017

Added right padding to dismissible alerts to avoid button/text overlap.

Fixes #24469

Comment thread scss/_alert.scss Outdated

.alert-dismissible {
padding-right: ($close-font-size + $alert-padding-x);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected whitespace at end of line no-eol-whitespace

Copy link
Copy Markdown
Collaborator

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good solution. There is more information on whats the result of this PR here #24469

Thanks @Kopyov

@andresgalante andresgalante requested a review from mdo October 20, 2017 19:32
@mdo mdo merged commit 0a82cd9 into twbs:v4-dev Oct 22, 2017
@mdo mdo mentioned this pull request Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants