Extend spacers and sizes#25101
Extend spacers and sizes#25101mdo merged 3 commits intotwbs:v4-devfrom unrevised6419:extend-spacers-sizes
Conversation
|
I suppose all our Sass maps should behave the same way—it'd make documentation easier. The only problem is removing values from the maps this way—you have to use |
| // variables. Mostly focused on spacing. | ||
| // You can add more entries to the $spacers map, should you need more variation. | ||
|
|
||
| // stylelint-disable |
There was a problem hiding this comment.
Can't we be more explicit with what we disable here?
There was a problem hiding this comment.
As in case for other empty maps. Stylelint does not allow empty maps ex:
// stylelint-disable
$grays: () !default;
// ...
$colors: () !default;
// ...
$theme-colors: () !default;
// ...
// stylelint-enablehttps://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss#L11
Should I add a comment line in code why I disable it?
There was a problem hiding this comment.
No worries, I remembered I had to do the same there when we switched to stylelint.
|
To add/modify values in |
|
UPDATE: You can't do this. |
Extend
$spacersand$sizeslike$theme-colorsand other maps.Used
// stylelint-disablebecausestylelintcomplains about map on single line.ps: Can
$grid-breakpointsand$container-max-widthsalso be extended like this?