Sort ascending $grid-breakpoints and $container-max-widths maps#25392
Closed
unrevised6419 wants to merge 2 commits intotwbs:v4-devfrom
unrevised6419:extend-grid-breakpoints
Closed
Sort ascending $grid-breakpoints and $container-max-widths maps#25392unrevised6419 wants to merge 2 commits intotwbs:v4-devfrom unrevised6419:extend-grid-breakpoints
$grid-breakpoints and $container-max-widths maps#25392unrevised6419 wants to merge 2 commits intotwbs:v4-devfrom
unrevised6419:extend-grid-breakpoints
Conversation
Member
|
Nice, thanks for this. Give me some time to review and test those new functions :). |
MartijnCuppens
previously requested changes
Dec 5, 2018
Member
unrevised6419
changed the title
$grid-breakpoints and $container-max-widths maps$grid-breakpoints and $container-max-widths maps
…me-colors` When extending `$grid-breakpoints` and `$container-max-widths` we must be sure that they are sorted ascending, added a new functions that sorts maps by their values. Now `_assert-ascending` it seems to be obsolete if we sort maps before that If user extends mentioned vars after `variables` import `map-sort-by-values` must be called again to be sure they are sorted
Author
|
@MartijnCuppens any feedback here? As I see, merging maps has been reverted. |
Member
|
Hi @iamandrewluca That being said, I'm quite impressed by the function you made here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extendsee #26714$grid-breakpointsand$container-max-widthsmaps, as$theme-colorsWhen extending
$grid-breakpointsand$container-max-widthswe mustbe sure that they are sorted ascending, added a new function that sorts maps by their values.
Now
_assert-ascendingcall it seems to be obsolete if we sort maps before thatIf user extends mentioned vars after
variablesimportmap-sort-by-valuesmust be called again to be sure they are sorted