Update dependencies. by XhmikosR · Pull Request #25840 · twbs/bootstrap

XhmikosR · 2018-03-13T17:11:36Z

I left workbox-build @2.1.3 since I can't find any docs what they have changed and with v3.0.0 it's broken.

Maybe @Lyricalz can help us out :)

TODO:

Use sinon from a CDN
Use QUnit from a CDN
Update workbox to v3.0.0

Johann-S · 2018-03-14T08:06:11Z

There are a new release of Popper.js (released yesterday): 1.14.1

Johann-S · 2018-03-14T08:09:30Z

    "shelljs": "^0.8.1",
    "shx": "^0.2.2",
-    "sinon": "^4.4.3",
+    "sinon": "^4.4.5",


~~should we upgrade to their new major release Sinon 5 ? Because currently we haven't unit tests which use Sinon (but it'll happen soon)~~

Hmm no finally Sinon 5 isn't ready

XhmikosR · 2018-03-14T11:17:58Z

There are a new release of Popper.js (released yesterday): 1.14.1

Yeah, but it doesn't have any changes to the dist files as far as I can tell.

As for sinon, I wasn't sure if v5 works so I stayed with v4 to be safe.

Johann-S · 2018-03-14T12:34:37Z

We cannot update to QUnit 2.5.1 because of karma-qunit which seems dead... See: karma-runner/karma-qunit#98

XhmikosR · 2018-03-14T12:43:50Z


    <!-- Sinon -->
-    <script src="https://cdnjs.cloudflare.com/ajax/libs/sinon.js/4.4.3/sinon-no-sourcemaps.min.js"></script>
+    <script src="https://cdnjs.cloudflare.com/ajax/libs/sinon.js/4.4.5/sinon-no-sourcemaps.min.js"></script>


It's 404 that is why I haven't changed it. Please revert it.

Indeed ! My bad

MikeyBeLike · 2018-03-14T13:15:12Z

@XhmikosR I can make a commit this week?

XhmikosR · 2018-03-14T13:57:29Z

@Lyricalz: sure thing, just CC me!

Johann-S · 2018-03-14T13:58:58Z

Finally karma-runner/karma-qunit#98 is merged, so we'll have to wait for their next release 👍

XhmikosR · 2018-03-14T14:00:51Z

Cool, @Johann-S feel free to push here when done.

@Lyricalz: please target this branch in your workbox update PR so that we have everything in one place.

Johann-S · 2018-03-16T10:17:47Z

I updated karma-qunit on my local branch and it doesn't work... So currently I don't understand where it failed in our karma plugins... Or if it's Karma itself

MikeyBeLike · 2018-03-16T21:11:06Z

Made a PR for workbox here: #25873

XhmikosR · 2018-03-20T15:48:00Z

@Johann-S: it seems we are hitting https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module

I also updated karma-qunit and switched to qunit.

I think after we fix this new error, only the CDN switch is left along with updating qunit in tests.

Johann-S · 2018-03-20T15:56:33Z

I don't think it's related to Rollup or Babel Plugins helpers but more related to : @babel/proposal-object-rest-spread which allow us to use object spread operator (see: https://travis-ci.org/twbs/bootstrap/jobs/355916540#L629 and https://github.com/twbs/bootstrap/blob/v4-dev/.babelrc.js#L14)

Maybe npm install --save-dev @babel/plugin-proposal-object-rest-spread should help us 🤔

Johann-S · 2018-03-20T21:12:40Z

I fixed the previous error but they are another one 😢

Edit:
If I set qunitjs to 2.4.1 and karma-qunit to 1.2.1 everything works...

XhmikosR · 2018-03-20T21:49:41Z

I guess I will revert that but it would be nice if we could pinpoint the cause and report it or fix it.

…

On Tue, Mar 20, 2018, 23:47 Johann-S ***@***.***> wrote: If I set qunitjs to 2.4.1 and karma-qunit to 1.2.1 everything works... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25840 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtajArJ4-xcud1lMubt6kS4i30Sflks5tgXkAgaJpZM4SpGU5> .

Johann-S · 2018-03-20T22:01:30Z

I checked a lot karma-qunit and for me it's more related to a change in QUnit which should be handled in karma-qunit

XhmikosR · 2018-03-20T23:14:15Z

I'll try downgrading karma-qunit tomorrow, unless you beat me to it.

Kept back karma-qunit and qunitjs because tests fail.

XhmikosR · 2018-03-21T09:38:24Z

I downgraded karma-qunit and qunitjs and tests work again.

This reduces duplication and the chances to forget to update something.

XhmikosR added build v4 labels Mar 13, 2018

XhmikosR requested a review from Johann-S March 13, 2018 17:11

XhmikosR force-pushed the v4-dev-xmr-update-deps branch from effb4ac to e35d4db Compare March 13, 2018 23:35

Johann-S reviewed Mar 14, 2018

View reviewed changes

XhmikosR added help wanted on-hold labels Mar 14, 2018

XhmikosR commented Mar 14, 2018

View reviewed changes

Johann-S force-pushed the v4-dev-xmr-update-deps branch from 670b9ff to eb001da Compare March 14, 2018 13:07

MikeyBeLike mentioned this pull request Mar 16, 2018

Update to workbox 3.0.0 & fix breaking changes #25873

Merged

XhmikosR force-pushed the v4-dev-xmr-update-deps branch from a3ff86f to df47127 Compare March 20, 2018 15:47

XhmikosR removed help wanted on-hold labels Mar 20, 2018

XhmikosR added 2 commits March 21, 2018 11:36

Update dependencies.

d1dae7d

tests: use QUnit from the jQuery CDN.

2ac3dec

XhmikosR and others added 6 commits March 21, 2018 11:36

Use sinon from cdnjs.

b03574d

Update to workbox 3.0 & fix breaking changes

8ddb04d

sw.js: fix TypeError with new workbox.

af1aa3e

Update workbox.js

221bcf7

Update all devDependencies.

4afeee9

Kept back karma-qunit and qunitjs because tests fail.

fix rollup config

2a59bab

XhmikosR force-pushed the v4-dev-xmr-update-deps branch from 1a67a9f to 2a59bab Compare March 21, 2018 09:38

tests: load 3rd-party libs from the local node_modules folder.

4ac84ad

This reduces duplication and the chances to forget to update something.

Johann-S approved these changes Mar 21, 2018

View reviewed changes

Remove the local jquery-1.9.1.min.js.

702fcb3

XhmikosR force-pushed the v4-dev-xmr-update-deps branch from 9919b4c to 702fcb3 Compare March 21, 2018 10:05

mdo mentioned this pull request Mar 21, 2018

v4.1 ship list #25375

Closed

XhmikosR merged commit 2cd7003 into v4-dev Mar 21, 2018

XhmikosR deleted the v4-dev-xmr-update-deps branch March 21, 2018 10:15

Uh oh!

Conversation

XhmikosR commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Johann-S commented Mar 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Johann-S Mar 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XhmikosR commented Mar 14, 2018

Uh oh!

Johann-S commented Mar 14, 2018

Uh oh!

XhmikosR Mar 14, 2018

Choose a reason for hiding this comment

Uh oh!

Johann-S Mar 14, 2018

Choose a reason for hiding this comment

Uh oh!

MikeyBeLike commented Mar 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XhmikosR commented Mar 14, 2018

Uh oh!

Johann-S commented Mar 14, 2018

Uh oh!

XhmikosR commented Mar 14, 2018

Uh oh!

Johann-S commented Mar 16, 2018

Uh oh!

MikeyBeLike commented Mar 16, 2018

Uh oh!

XhmikosR commented Mar 20, 2018

Uh oh!

Johann-S commented Mar 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Johann-S commented Mar 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XhmikosR commented Mar 20, 2018 via email

Uh oh!

Johann-S commented Mar 20, 2018

Uh oh!

XhmikosR commented Mar 20, 2018

Uh oh!

XhmikosR commented Mar 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

XhmikosR commented Mar 13, 2018 •

edited

Loading

Johann-S commented Mar 14, 2018 •

edited

Loading

Johann-S Mar 14, 2018 •

edited

Loading

MikeyBeLike commented Mar 14, 2018 •

edited

Loading

Johann-S commented Mar 20, 2018 •

edited

Loading

Johann-S commented Mar 20, 2018 •

edited

Loading