Skip to content

Update to workbox 3.0.0 & fix breaking changes#25873

Merged
XhmikosR merged 3 commits intotwbs:v4-dev-xmr-update-depsfrom
MikeyBeLike:workbox-update
Mar 20, 2018
Merged

Update to workbox 3.0.0 & fix breaking changes#25873
XhmikosR merged 3 commits intotwbs:v4-dev-xmr-update-depsfrom
MikeyBeLike:workbox-update

Conversation

@MikeyBeLike
Copy link
Copy Markdown
Contributor

@MikeyBeLike MikeyBeLike commented Mar 16, 2018 •
edited
Loading

#25840

cc @XhmikosR

Let me know if this is any good?

@MikeyBeLike MikeyBeLike mentioned this pull request Mar 16, 2018
Merged
3 tasks
@MikeyBeLike MikeyBeLike changed the title Update to workbox 3.0 & fix breaking changes Update to workbox 3.0.0 & fix breaking changes Mar 16, 2018
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Mar 17, 2018

Thanks! I'll have a look tomorrow.

@XhmikosR XhmikosR self-assigned this Mar 17, 2018
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Mar 20, 2018 •
edited
Loading

@Lyricalz: seems to work, but I get an error in browser console:

TypeError: self.WorkboxSW is not a constructor

>> const workboxSW = new self.WorkboxSW()

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Mar 20, 2018

Never mind, was easy to fix :)

@XhmikosR XhmikosR merged commit a3ff86f into twbs:v4-dev-xmr-update-deps Mar 20, 2018
@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Mar 20, 2018

Thanks!

@mdo mdo mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@XhmikosR XhmikosR

Labels

build v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MikeyBeLike @XhmikosR