Replace reboot monospace hack with system font stack issue #26228#26257
Replace reboot monospace hack with system font stack issue #26228#26257mdo merged 1 commit intotwbs:v4-devfrom client9:monospace-stack
Conversation
|
Only issue I see with this, is that the standalone reboot won't have this fix any longer. And it seems it's still required by some browsers. Alternatively, maybe we could do this conditionally. I'll leave the final decision to @mdo. |
|
hi @XhmikosR -- my understanding of the monospace hack is that some browser/os combos have a hardwired "if and only if the font-family is exactly "monospace" then do something stupid with sizing". This is why "monospace, monospace" prevents the issue. Using something other than |
|
Yeah, I understand this, but Bootstrap Reboot is a separate project/file. |
|
hi @XhmikosR Oh i see. For bootstrap is this a non-change (except smaller, less redundant rules), but for reboot it would change the font used (assuming it's not changed downstream). So that would be a @mdo decision on what to do. got it! thanks for your time guys. Let me know if you need any additional details. regards --nickg |
All test pass. Spot check on my personal site seems to be fine. Saves a whole 50 bytes minified, and 10 bytes compressed. 🔢
I left the odd "font-size: 1em" since I'm unclear exactly what this does. It's likely wrong (want rem) or un-necessarly or both, but this is enough change for this commit.
Comments welcome.
Fixes #26228