Don't run Google Analytics locally.#28384
Don't run Google Analytics locally.#28384XhmikosR merged 1 commit intotwbs:v4-dev-xmr-hugo-2from coliff:patch-1
Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-hugo-2
branch
2 times, most recently
from
d9ed015 to
64db4c2
Compare
|
Nvm, I don't think it resolves #28351. Oh, and please remove the |
XhmikosR
force-pushed
the
v4-dev-xmr-hugo-2
branch
from
d65a453 to
9819140
Compare
|
hey @XhmikosR - sorry not got back to this yet. Do I need to do anything now? |
|
@coliff: yeah, all of the above :) |
XhmikosR
force-pushed
the
v4-dev-xmr-hugo-2
branch
6 times, most recently
from
b612a75 to
c8f4cc5
Compare
|
Not sure how to proceed with this honestly. I personally have no issue with this, nor with the analytics running. But I still need to above things fixed in order to merge it. /CC @MartijnCuppens @Johann-S @mdo for thoughts. |
|
Rebase here got messed up. |
|
Yeah but do you want this change? I will take care if it myself, I'm just
not sure 100% I want this. Both ways are Ok to me
…On Tue, Mar 12, 2019, 22:22 Mark Otto ***@***.***> wrote:
Rebase here got messed up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28384 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtRwMpD4w5SCElBI2v7VWTms8LnR-ks5vWAyOgaJpZM4bYKFL>
.
|
I can't see what the diff is easily, but based on the title here, I'm good not running Google Analytics on localhost while doing development. I'm also good not running it on Netlify fwiw. |
|
The diff is just the last patch, the rest will go away with a proper rebase. @coliff I will make the changes, but it'd be nice if you could take care of the comments yourself in the future. |
XhmikosR
changed the title
It just isn't of any real use for me. Whoever wants to block GA locally, they can do it on their side.
It just isn't of any real use for me. Whoever wants to block GA locally, they can do it on their side.
4 participants
This is for the Hugo docs.
Refs #28351