Skip to content

Revert "Don't run Google Analytics locally. (#28384)#28489

Merged
mdo merged 2 commits intomasterfrom
docs-ga
Mar 14, 2019
Merged

Revert "Don't run Google Analytics locally. (#28384)#28489
mdo merged 2 commits intomasterfrom
docs-ga

Conversation

@mdo
Copy link
Copy Markdown
Member

@mdo mdo commented Mar 14, 2019

Reverts #28384.

Second of two PRs to supersede #28486.

It just isn't of any real use for me. Whoever wants to block GA locally, they can do it on their side.
@mdo
Copy link
Copy Markdown
Member Author

mdo commented Mar 14, 2019

Currently doing some light reading into GDPR and GA. #28351 was opened by a deleted account and while the motivation for that issue is in question, there do seem to be some things we should audit and consider. Hence, this PR.

@XhmikosR
Copy link
Copy Markdown
Member

I don't this really solves anything hence the revert.

If we want to care about GDPR we should do it properly in another PR.

@mdo
Copy link
Copy Markdown
Member Author

mdo commented Mar 14, 2019

Having reviewed our GA settings, the data retention period looks good and no data is being shared with Google's advertising or any other partner (thus, no need for consent to sharing data as I understand it). Whatever GA collects stays in GA.

Will revisit and confirm Carbon separately.

@mdo mdo merged commit 43eb6b1 into master Mar 14, 2019
@mdo mdo deleted the docs-ga branch March 14, 2019 02:07
@XhmikosR
Copy link
Copy Markdown
Member

Just so we are on the same side, GDPR isn't about that. We need to inform every visitor their data is being collected and get their consent.

That being said, we can at least anonymize the IPs in GA. I will make a PR for this tomorrow.

@mdo
Copy link
Copy Markdown
Member Author

mdo commented Mar 14, 2019

I understand GDPR is about both—collection and sharing. My last comment was from reading multiple articles that has that guidance for GA as it relates to sharing though. Still reading more about it though and will see what we need to do for the pure collection aspect.

I'm no expert, so keep me honest. Just sharing what I'm learning along the way.

That being said, we can at least anonymize the IPs in GA. I will make a PR for this tomorrow.

Awesome, thanks for that!

@mdo mdo mentioned this pull request Mar 14, 2019
@mdo
Copy link
Copy Markdown
Member Author

mdo commented Mar 14, 2019

Actually while reviewing our GA settings, realized we're on an old script and we can anonymize from that new one. See first stab at #28491 before getting going @XhmikosR.

@bardiharborow
Copy link
Copy Markdown
Member

This wasn't about GDPR, but rather that local users should not have their information beamed to GA (because local files don't match the domain, I think GA rejects their pings anyway). The references to ga in onclick handlers need to be made conditional on .Site.IsServer as well and then this won't throw errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants