Skip to content

Added focus state to .btn-link#30036

Merged
MartijnCuppens merged 3 commits intotwbs:masterfrom
timdujardin:29891
Mar 23, 2020
Merged

Added focus state to .btn-link#30036
MartijnCuppens merged 3 commits intotwbs:masterfrom
timdujardin:29891

Conversation

@timdujardin
Copy link
Copy Markdown
Contributor

@timdujardin timdujardin commented Jan 17, 2020

@XhmikosR
Copy link
Copy Markdown
Member

Isn't v4 affected by this? If so, we better backport this.

@XhmikosR
Copy link
Copy Markdown
Member

Moving this to v5. @patrickhlauke please have a look :) Also, @ysds @MartijnCuppens

@patrickhlauke
Copy link
Copy Markdown
Member

patrickhlauke commented Mar 19, 2020

isn't the point of .btn-link that it's a button, but will look like a link? which is does by showing the underline?

[edit: ah, but i see that we've changed the focus style for links anyway to show outline - or was it always like that and i just missed it? been a while - so yeh sure]

Copy link
Copy Markdown
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need some kind of focus indication when #30389 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Focus state removed from btn-link:focus ruleset

5 participants