Skip to content

added border on focus of hambuger icon#30540

Closed
TorRydberg wants to merge 4 commits intotwbs:masterfrom
TorRydberg:torBranch
Closed

added border on focus of hambuger icon#30540
TorRydberg wants to merge 4 commits intotwbs:masterfrom
TorRydberg:torBranch

Conversation

@TorRydberg
Copy link
Copy Markdown

@TorRydberg TorRydberg commented Apr 8, 2020

Fixes #30420

@TorRydberg TorRydberg requested a review from a team as a code owner April 8, 2020 18:22
Comment thread site/assets/scss/_subnav.scss Outdated
color: $gray-900;
}

.bd-search-docs-toggle:focus {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this in under the selector in line 39 and make sure CI passes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and commited again, all tests passed.

@XhmikosR XhmikosR requested a review from patrickhlauke April 9, 2020 05:17
@MartijnCuppens
Copy link
Copy Markdown
Member

Closing this since #30036 already fixed this.

@TorRydberg TorRydberg deleted the torBranch branch April 9, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation hamburger button lacks visible focus indication

3 participants