Prevent grid with default cols from breaking when large pre is present#30049
Merged
XhmikosR merged 3 commits intotwbs:masterfrom Jan 25, 2020
Merged
Prevent grid with default cols from breaking when large pre is present#30049XhmikosR merged 3 commits intotwbs:masterfrom
XhmikosR merged 3 commits intotwbs:masterfrom
Conversation
dcfe5d6 to
0540ec4
Compare
Member
|
Does this apply to v4 @MartijnCuppens? if so please add the label and project in the PRs you approve. |
XhmikosR
pushed a commit
that referenced
this pull request
Jan 28, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Feb 4, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Feb 16, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Feb 17, 2020
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
|
Did this one get re-introduced? I noticed this behavior on 4.6.1 and saw this section had been changed: bootstrap/scss/mixins/_grid-framework.scss Lines 24 to 27 in af78de3 and didn't see any min-width here: bootstrap/scss/mixins/_grid-framework.scss Lines 8 to 13 in af78de3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25410 (Codepen with bug present in issue)
Tested this in Codepen: https://codepen.io/jensluyten/pen/povxyPe.
The
min-width: 0;on the.colactually prevents the col from taking up the entire row space.This was only an issue on the default cols, because specified cols have a fixed
flex-basisproperty that prevents this issue from happening.