Skip to content

min-width: 0 on .col has too much side-effects#30979

Merged
XhmikosR merged 3 commits intomasterfrom
master-fod-col-min-width
Jun 9, 2020
Merged

min-width: 0 on .col has too much side-effects#30979
XhmikosR merged 3 commits intomasterfrom
master-fod-col-min-width

Conversation

@ffoodd
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd commented Jun 8, 2020

Closes #30852

For some reason I cannot revert the merged commit. So let's simply drop it.

Flexible items are flexible, so in order to fix what #30049 tried to fix: either use fixed width on pre, or let it wrap by using:

.col > pre {
  white-space: pre-wrap;
}

@ffoodd ffoodd requested a review from a team as a code owner June 8, 2020 09:40
@XhmikosR XhmikosR requested a review from MartijnCuppens June 9, 2020 04:50
@XhmikosR XhmikosR merged commit 32d18d1 into master Jun 9, 2020
@XhmikosR XhmikosR deleted the master-fod-col-min-width branch June 9, 2020 18:49
@XhmikosR
Copy link
Copy Markdown
Member

@ffoodd can you backport this manually please? It conflicts.

XhmikosR pushed a commit that referenced this pull request Jun 10, 2020
fix(grid)[manual backport]: zero min-width on .col has too much side-effects
@poebrand
Copy link
Copy Markdown

poebrand commented Jul 9, 2020

Hi @ffoodd and @mdo ,

According to https://github.com/twbs/bootstrap/releases , the last 4.x release was May 12th. However, this fix was put in place on June 9th.

Is it possible to get another 4.x release so this fix can go out? We just ran into the problem as well.

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Col min-width: 0 affects responsive behavior

5 participants