Skip to content

Switch to strings constants.#30358

Merged
XhmikosR merged 2 commits intomasterfrom
master-xmr-constants-string
Mar 18, 2020
Merged

Switch to strings constants.#30358
XhmikosR merged 2 commits intomasterfrom
master-xmr-constants-string

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Mar 7, 2020

This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

This is an update/continuation of #21711.

Fixes #20011

File Before After Diff
bootstrap.bundle.min.js 23.61 kB 22.61 kB -1.00 kB (-4.23 %)
bootstrap.min.js 17.04 kB 16.08 kB -0.96 kB (-5.63 %)

Preview: https://deploy-preview-30358--twbs-bootstrap.netlify.com/

TODO:

  • popover
  • tooltip
  • take care of any newly added TODO comments

@XhmikosR
Copy link
Copy Markdown
Member Author

XhmikosR commented Mar 8, 2020

I could use some help with popover and tooltip Event getter

@XhmikosR XhmikosR force-pushed the master-xmr-constants-string branch 3 times, most recently from 24fabae to 7b326e9 Compare March 9, 2020 16:10
@XhmikosR XhmikosR marked this pull request as ready for review March 17, 2020 13:30
@XhmikosR XhmikosR requested a review from a team as a code owner March 17, 2020 13:30
@XhmikosR XhmikosR force-pushed the master-xmr-constants-string branch from 848fdcd to 3e2d096 Compare March 17, 2020 13:30
@XhmikosR XhmikosR requested a review from Johann-S March 18, 2020 07:47
@XhmikosR XhmikosR force-pushed the master-xmr-constants-string branch from 0fe28b7 to ecbf833 Compare March 18, 2020 07:57
This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

While at it, remove a few unused properties.

File                        Before      After       Diff
--------------------------------------------------------
bootstrap.bundle.min.js     23.61 kB    22.61 kB    -1.00 kB (-4.23 %)
bootstrap.min.js            17.04 kB    16.08 kB    -0.96 kB (-5.63 %)
@XhmikosR XhmikosR force-pushed the master-xmr-constants-string branch from 5344060 to c3b36d3 Compare March 18, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v5: JS constant declaration / minification

2 participants