Skip to content

Switch to string constants.#30490

Merged
XhmikosR merged 2 commits intov4-devfrom
v4-dev-xmr-const-strings
Mar 31, 2020
Merged

Switch to string constants.#30490
XhmikosR merged 2 commits intov4-devfrom
v4-dev-xmr-const-strings

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Mar 31, 2020

This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

While at it, remove a few unused properties.

File Before After Diff
bootstrap.bundle.min.js 22.09 kB 21.13 kB -0.96 kB (-4.35 %)
bootstrap.min.js 15.4 kB 14.46 kB -0.94 kB (-3.86 %)

Refs #20011, refs #30358

Preview: https://deploy-preview-30490--twbs-bootstrap.netlify.com/

This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

While at it, remove a few unused properties.

File                        Before      After       Diff
--------------------------------------------------------
bootstrap.bundle.min.js     22.09 kB    21.13 kB    -0.96 kB (-4.35 %)
bootstrap.min.js            15.4 kB     14.46 kB    -0.94 kB (-3.86 %)
@XhmikosR XhmikosR marked this pull request as ready for review March 31, 2020 15:03
@XhmikosR XhmikosR requested a review from a team as a code owner March 31, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants