Add Sass docs (variables, mixins, and loops) to most pages#32747
Merged
Conversation
This was referenced Jan 10, 2021
Closed
mdo
changed the title
XhmikosR
force-pushed
the
component-sass-docs
branch
from
99d28db to
5e5d61c
Compare
Member
|
Looking good so far! I wonder if it's intentional, button group does not have any Sass section. There might be more components/utilities that are missing. EDIT: Also, do note that linkinator won't catch any missing/broken anchors. We might hit this in the future. There's a request upstream, though. |
XhmikosR
reviewed
Jan 13, 2021
Closed
ffoodd
approved these changes
Jan 15, 2021
mdo
force-pushed
the
component-sass-docs
branch
from
1ce7225 to
fa0d122
Compare
Member
|
@mdo this PR contains dis files changes :/ |
Member
Author
|
Oh woof my bad. I can revert later and fix. |
Member
|
@mdo yeah please revert because you committed changes that shouldn't be there :/ Remember to do |
mdo
added a commit
that referenced
this pull request
Feb 11, 2021
XhmikosR
pushed a commit
that referenced
this pull request
Feb 11, 2021
This was referenced Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #25977, figured I'd take a stab at what we could do for documenting our Sass better. This is similar to our JS docs for methods, options, etc. I think this is doable, just a little more manual than a purely generated mixins docs page.
Preview: https://deploy-preview-32747--twbs-bootstrap.netlify.app
TODO: