Conversation
|
@XhmikosR Elaborating per Slack... the latest commit here should break the build because there's indentation before the comment lines. |
|
Looking solid @XhmikosR, thanks! One thing for your referenced PR, it'd be awesome to un-indent these lines if possible. Right now the snippet brings in those extra spaces. That might be too difficult, so not a huge deal if so. |
- Split colors from background utilities with new docs page - Add Sass docs for both pages
Should work now with indented start/end capture statements
Yup, I know, it's in my TODO after this one lands :) |
e3e90b4 to
67add99
Compare
| - title: API | ||
| - title: Background | ||
| - title: Borders | ||
| - title: Colors |
There was a problem hiding this comment.
Shouldn't this be renamed as Color for consistency? Questionning only, no opinion.
There was a problem hiding this comment.
We actually seem to mix and match these... we have Interactions, shadows etc. We should probably streamline these at some point and add redirects.
The
scss-docsshortcode is amazing, but one limitation is it doesn't seem to work with indentation at the beginning of the single line comments to identify sections. This is what I ran into in #32747 with documenting the utilities map. Curious if @MartijnCuppens or @XhmikosR has some ideas for how to address that.Also documents the existence of
.bg-body, closing the docs part of #32810.Still a little copyediting to refine here, so consider this one a little WIP still.