Skip to content

docs: shortcodes tweaks and consistency changes#32781

Merged
XhmikosR merged 6 commits intomainfrom
XhmikosR-patch-9
Aug 31, 2021
Merged

docs: shortcodes tweaks and consistency changes#32781
XhmikosR merged 6 commits intomainfrom
XhmikosR-patch-9

Conversation

@XhmikosR
Copy link
Copy Markdown
Member

@XhmikosR XhmikosR commented Jan 13, 2021 •
edited
Loading

TODO:

  • scss-docs: un-indent these lines if possible. Right now the snippet brings in those extra spaces
  • Make sure we check for the needed shortcode parameters in all shortcodes and if not present throw and error

@XhmikosR XhmikosR marked this pull request as ready for review January 13, 2021 22:36
@XhmikosR XhmikosR changed the title Tweak scss-docs shortcode Minor scss-docs shortcode tweaks Jan 15, 2021
@XhmikosR XhmikosR marked this pull request as draft January 16, 2021 19:51
@XhmikosR XhmikosR changed the title Minor scss-docs shortcode tweaks docs: shortcodes tweaks Jan 16, 2021
@XhmikosR XhmikosR changed the title docs: shortcodes tweaks docs: shortcodes tweaks and consistency changes Jan 16, 2021
@XhmikosR XhmikosR force-pushed the XhmikosR-patch-9 branch 2 times, most recently from 2bef7b3 to 9d099e7 Compare January 17, 2021 14:55
@XhmikosR XhmikosR mentioned this pull request Jan 20, 2021
Merged
3 tasks
@XhmikosR XhmikosR force-pushed the XhmikosR-patch-9 branch 6 times, most recently from 3b7c6a4 to 699f5d8 Compare January 20, 2021 19:52
@XhmikosR XhmikosR force-pushed the XhmikosR-patch-9 branch 3 times, most recently from 8cb2eac to 124b867 Compare February 4, 2021 06:44
@twbs twbs deleted a comment from cloudflare-workers-and-pages Bot Mar 5, 2021
@XhmikosR XhmikosR requested a review from mdo July 29, 2021 04:39
@XhmikosR XhmikosR marked this pull request as ready for review July 29, 2021 04:39
@XhmikosR XhmikosR requested a review from a team as a code owner July 29, 2021 04:39
@XhmikosR
Copy link
Copy Markdown
Member Author

XhmikosR commented Jul 29, 2021

@mdo I can't fix the indentation for the love of me :/ So, I'd say let's merge this PR as is without squashing and we open a new issue for the indentation.

@GeoSot GeoSot self-requested a review August 30, 2021 12:53
@XhmikosR XhmikosR removed the request for review from a team August 30, 2021 14:39
@XhmikosR XhmikosR merged commit 283cbd9 into main Aug 31, 2021
@XhmikosR XhmikosR deleted the XhmikosR-patch-9 branch August 31, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoSot GeoSot GeoSot approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees

No one assigned

Labels

backport-to-v4 docs no squash v4 v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XhmikosR @GeoSot @mdo